[GitHub] cassandra issue #253: CASSANDRA-13630

[jasobrown <gi...@git.apache.org>]

Github user jasobrown commented on the issue:

    https://github.com/apache/cassandra/pull/253
  
    Wait for CASSANDRA-14503 :)
    
    On Sun, Sep 9, 2018 at 18:37 Dinesh <no...@github.com> wrote:
    
    > *@dineshjoshi* commented on this pull request.
    > ------------------------------
    >
    > In test/unit/org/apache/cassandra/net/async/ChannelWriterTest.java
    > <https://github.com/apache/cassandra/pull/253#discussion_r216180830>:
    >
    > >          channel = new EmbeddedChannel();
    >          omc = new NonSendingOutboundMessagingConnection(id, null, Optional.empty());
    > -        channelWriter = ChannelWriter.create(channel, omc::handleMessageResult, Optional.empty());
    > -        channel.pipeline().addFirst(new MessageOutHandler(id, MessagingService.current_version, channelWriter, () -> null));
    > -        coalescingStrategy = CoalescingStrategies.newCoalescingStrategy(CoalescingStrategies.Strategy.FIXED.name(), COALESCE_WINDOW_MS, null, "test");
    > +        wrapper = new MessageOutWrapper();
    > +        OutboundConnectionParams.Builder builder = OutboundConnectionParams.builder()
    > +                                                                           .messageResultConsumer(this::handleMessageResult)
    > +                                                                           .coalescingStrategy(Optional.empty())
    > +                                                                           .protocolVersion(MessagingService.current_version)
    > +                                                                           .connectionId(id);
    > +
    > +        if (type == ChannelWriterType.COALESCING)
    > +            coalescingStrategy = CoalescingStrategies.newCoalescingStrategy(CoalescingStrategies.Strategy.FIXED.name(), COALESCE_WINDOW_MS, null, "test");
    > +        else
    > +            coalescingStrategy = Optional.empty();
    >
    > This is beyond the scope of this PR, however, we should refactor
    > OutboundConnectionParams to not store an Optional.
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/cassandra/pull/253#pullrequestreview-153604787>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ABVYQazZAIsQIg5RPNy6jGI5KELiH5Cdks5uZcJYgaJpZM4WGkHi>
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org