You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-commits@incubator.apache.org by "Adrián Boimvaser (Created JIRA)" <ji...@apache.org> on 2011/12/21 13:17:30 UTC
[jira] [Created] (NPANDAY-510) Allow wix-maven-plugin to configure
wix home
Allow wix-maven-plugin to configure wix home
--------------------------------------------
Key: NPANDAY-510
URL: https://issues.apache.org/jira/browse/NPANDAY-510
Project: NPanday
Issue Type: Improvement
Components: Maven Plugins
Affects Versions: 1.4-incubating
Reporter: Adrián Boimvaser
Fix For: 1.4.1-incubating, 1.5.0-incubating
At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
it would be nice to be able to specify the location of the wix installation via a configuration parameter
<configuration>
<wixHome>C:\wix</wixHome>
...
</configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NPANDAY-510) Allow wix-maven-plugin to
configure wix home
Posted by "Adrián Boimvaser (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175019#comment-13175019 ]
Adrián Boimvaser commented on NPANDAY-510:
------------------------------------------
In my particular case WIX is located relative to my source code (an svn:external)
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.4.1-incubating, 1.5.0-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NPANDAY-510) Allow wix-maven-plugin to
configure wix home
Posted by "Lars Corneliussen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174989#comment-13174989 ]
Lars Corneliussen commented on NPANDAY-510:
-------------------------------------------
I'd like to discuss "%PATH%" with you :)
I really don't like that NPanday requires things to be on the path. Instead I'd like a standard way to specify paths for executables - theese should also work with multiple versions and OS per se; but maybe it is overkill for those just building one version on one environmen anyway?
Also wix-plugin doesn't make use of the standard executable facilities in NPanday (look at msdeploy/azure plugins) - which i did refactor a lot in 1.5.0-incubating-SNAPSHOT. There we have support for versioning, default probing paths, ++;
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.4.1-incubating, 1.5.0-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NPANDAY-510) Allow wix-maven-plugin to configure
wix home
Posted by "Brett Porter (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter resolved NPANDAY-510.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.5.0-incubating)
applied patch, thanks! I adjusted it (and the surrounding code) so it would also work with paths with spaces (like Program Files), and to take Lars' suggestion to default to %WIX%
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Assignee: Brett Porter
> Fix For: 1.4.1-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NPANDAY-510) Allow wix-maven-plugin to configure
wix home
Posted by "Adrián Boimvaser (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrián Boimvaser updated NPANDAY-510:
-------------------------------------
Attachment: wixHome.patch
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.4.1-incubating, 1.5.0-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (NPANDAY-510) Allow wix-maven-plugin
to configure wix home
Posted by "Lars Corneliussen (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174994#comment-13174994 ]
Lars Corneliussen edited comment on NPANDAY-510 at 12/22/11 7:40 PM:
---------------------------------------------------------------------
Also by default we could try finding wix on %WIX%; but that is also version-independent.
BTW, maybe this is interesting for you: https://issues.apache.org/jira/browse/NPANDAY-499 (Second bullet point: Mojos should accept additional configurations as parameters (if probingPaths do not match, or a new version has not yet made it into NPanday))
was (Author: lcorneliussen):
Also by default we could try finding wix on %WIX%; but that is also version-independent.
BTW, maybe this is interesting for you: https://issues.apache.org/jira/browse/NPANDAY-499
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.4.1-incubating, 1.5.0-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (NPANDAY-510) Allow wix-maven-plugin to configure
wix home
Posted by "Lars Corneliussen (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Corneliussen reassigned NPANDAY-510:
-----------------------------------------
Assignee: Brett Porter
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Assignee: Brett Porter
> Fix For: 1.4.1-incubating, 1.5.0-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NPANDAY-510) Allow wix-maven-plugin to
configure wix home
Posted by "Lars Corneliussen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174994#comment-13174994 ]
Lars Corneliussen commented on NPANDAY-510:
-------------------------------------------
Also by default we could try finding wix on %WIX%; but that is also version-independent.
BTW, maybe this is interesting for you: https://issues.apache.org/jira/browse/NPANDAY-499
> Allow wix-maven-plugin to configure wix home
> --------------------------------------------
>
> Key: NPANDAY-510
> URL: https://issues.apache.org/jira/browse/NPANDAY-510
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.4-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.4.1-incubating, 1.5.0-incubating
>
> Attachments: wixHome.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> At this moment wix-maven-plugin expects candle.exe and light.exe to be on the path.
> it would be nice to be able to specify the location of the wix installation via a configuration parameter
> <configuration>
> <wixHome>C:\wix</wixHome>
> ...
> </configuration>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira