[jira] [Commented] (HIVE-17338) Utilities.get*Tasks multiple methods duplicate code

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159505#comment-16159505 ] 

Hive QA commented on HIVE-17338:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12886077/HIVE-17338.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 11033 tests executed
*Failed tests:*
{noformat}
TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=61)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=100)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=234)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6736/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6736/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6736/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12886077 - PreCommit-HIVE-Build

> Utilities.get*Tasks multiple methods duplicate code
> ---------------------------------------------------
>
>                 Key: HIVE-17338
>                 URL: https://issues.apache.org/jira/browse/HIVE-17338
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Gergely Hajós
>         Attachments: HIVE-17338.1.patch
>
>
> As discussed in https://github.com/apache/hive/pull/212/files, the 3 functions can share a more general function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)