[GitHub] [hive] prasanthj commented on pull request #1983: HIVE-24786: JDBC HttpClient should retry for idempotent and unsent http methods

[GitBox <gi...@apache.org>]

prasanthj commented on pull request #1983:
URL: https://github.com/apache/hive/pull/1983#issuecomment-780539112


   @szlta Thanks for the review!
   I tested the PR on different environment and ran into different set of issues (likely because of OS difference and JDK difference). Encountered a hang issue under some scenarios (socket read timeout). The hang is because there was no timeout defined on the socket created by httpclient and hence it will infinitely wait until server can write something to it (which will never happen because LB disconnected the connection to server). HIVE-12371 provided a way to specify socketTimeout via JDBC param but that was applied only for binary transport and not for http. 
   I made couple of changes to the PR and tested it to make sure the hang never happens
   1) For httpmode use the socketTimeout specified by the user via jdbc param
   2) The default retry handler does not retry InterruptedIOException. Since SocketTimeoutException (read timeout) is subclass of InterruptedIOException it wasn't retried. So added a custom retry handler with list of classes that will be retried in addition to the default retry (idempotent and unsent requests). 
   Could you please take another look at the PR as it has changed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org