You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/12/09 10:11:40 UTC
[GitHub] tajo pull request: TAJO-1238: Add SET SESSION and RESET statement.
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/294
TAJO-1238: Add SET SESSION and RESET statement.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #294
----
commit 021c872fbfedf90e5eb579dfe109590242fa1bae
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-09T01:00:24Z
Add session statement to parser.
commit 56b3016a579896e542a44289e59cc7cb769f8880
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-09T09:09:27Z
TAJO-1238: Add SET SESSION and RESET statement.
commit 46a99857a5adc7b30e532b6dd861157be8262d90
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-12-09T09:09:38Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1238
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1238: Add SET SESSION and RESET statement.
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/294#issuecomment-66418909
I fixed some unit test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1238: Add SET SESSION and RESET statement.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1238: Add SET SESSION and RESET statement.
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/294#issuecomment-66399315
@hyunsik
Could you fix the compilation error ?
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project tajo-catalog-common: Compilation failure
[ERROR] /Users/kimjh/asf-patch/incubator-tajo/tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java:[57,47] cannot find symbol
[ERROR] symbol : method isAlphabetic(char)
[ERROR] location: class java.lang.Character
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1238: Add SET SESSION and RESET statement.
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/294#issuecomment-66420984
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1238: Add SET SESSION and RESET statement.
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/294#issuecomment-66405440
I missed checking the compilation in JVM 6. I've updated the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---