You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by "John Williams (JIRA)" <ji...@apache.org> on 2007/01/12 17:16:28 UTC

[jira] Created: (IVY-388) Inconsistency in ConfigurationReport

Inconsistency in ConfigurationReport
------------------------------------

                 Key: IVY-388
                 URL: https://issues.apache.org/jira/browse/IVY-388
             Project: Ivy
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.4.1
         Environment: all
            Reporter: John Williams
            Priority: Minor


Please see the attached patch which adds a test case.  The patch assumes IVY-383-testcase.patch has been previously applied.  I'm not sure if this is a bug or just a misunderstanding, but it caused me a lot of confusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (IVY-388) Inconsistency in ConfigurationReport

Posted by "John Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Williams updated IVY-388:
------------------------------

    Attachment: IVY-388-testcase-2.patch

> Inconsistency in ConfigurationReport
> ------------------------------------
>
>                 Key: IVY-388
>                 URL: https://issues.apache.org/jira/browse/IVY-388
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.4.1
>         Environment: all
>            Reporter: John Williams
>            Priority: Minor
>         Attachments: IVY-388-testcase-2.patch, IVY-388-testcase.patch
>
>
> Please see the attached patch which adds a test case.  The patch assumes IVY-383-testcase.patch has been previously applied.  I'm not sure if this is a bug or just a misunderstanding, but it caused me a lot of confusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (IVY-388) Inconsistency in ConfigurationReport

Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464552 ] 

Maarten Coene commented on IVY-388:
-----------------------------------

I don't think this is a bug.

The ResolveReport.getDependencies() method returns all dependencies, including the evicted ones.
The ConfigurationResolveReport.getDependency() can also return an evicted dependency
The ConfigurationResolveReport.getModuleRevisionIds() doesn't return evicted dependencies.

So it's perfectly normal that the getDependency() method can return a result which is not contained in the getModuleRevisionIds().

Everything works fine if I modify your test into this:

if (!node.isEvicted(conf)) {
	boolean flag1 = report.getConfigurationReport(conf)
			.getDependency(node.getResolvedId()) != null;
	boolean flag2 = report.getConfigurationReport(conf)
			.getModuleRevisionIds().contains(node.getResolvedId());
	assertEquals("Inconsistent data for node " + node + " in conf " + conf , flag1, flag2);
}

Maarten

> Inconsistency in ConfigurationReport
> ------------------------------------
>
>                 Key: IVY-388
>                 URL: https://issues.apache.org/jira/browse/IVY-388
>             Project: Ivy
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.4.1
>         Environment: all
>            Reporter: John Williams
>            Priority: Minor
>         Attachments: IVY-388-testcase-2.patch, IVY-388-testcase.patch
>
>
> Please see the attached patch which adds a test case.  The patch assumes IVY-383-testcase.patch has been previously applied.  I'm not sure if this is a bug or just a misunderstanding, but it caused me a lot of confusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (IVY-388) Inconsistency in ConfigurationReport

Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maarten Coene updated IVY-388:
------------------------------

    Component/s:     (was: Core)
                 Documentation

I've set the 'Documentation' component because I think this could be avoided if the methods mentionned above were better documented.

> Inconsistency in ConfigurationReport
> ------------------------------------
>
>                 Key: IVY-388
>                 URL: https://issues.apache.org/jira/browse/IVY-388
>             Project: Ivy
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.4.1
>         Environment: all
>            Reporter: John Williams
>            Priority: Minor
>         Attachments: IVY-388-testcase-2.patch, IVY-388-testcase.patch
>
>
> Please see the attached patch which adds a test case.  The patch assumes IVY-383-testcase.patch has been previously applied.  I'm not sure if this is a bug or just a misunderstanding, but it caused me a lot of confusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (IVY-388) Inconsistency in ConfigurationReport

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Hanin updated IVY-388:
-----------------------------

    Fix Version/s: 1.5

> Inconsistency in ConfigurationReport
> ------------------------------------
>
>                 Key: IVY-388
>                 URL: https://issues.apache.org/jira/browse/IVY-388
>             Project: Ivy
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.4.1
>         Environment: all
>            Reporter: John Williams
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: IVY-388-testcase-2.patch, IVY-388-testcase.patch
>
>
> Please see the attached patch which adds a test case.  The patch assumes IVY-383-testcase.patch has been previously applied.  I'm not sure if this is a bug or just a misunderstanding, but it caused me a lot of confusion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (IVY-388) Inconsistency in ConfigurationReport

Posted by "John Williams (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Williams updated IVY-388:
------------------------------

    Attachment: IVY-388-testcase.patch

> Inconsistency in ConfigurationReport
> ------------------------------------
>
>                 Key: IVY-388
>                 URL: https://issues.apache.org/jira/browse/IVY-388
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.4.1
>         Environment: all
>            Reporter: John Williams
>            Priority: Minor
>         Attachments: IVY-388-testcase.patch
>
>
> Please see the attached patch which adds a test case.  The patch assumes IVY-383-testcase.patch has been previously applied.  I'm not sure if this is a bug or just a misunderstanding, but it caused me a lot of confusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira