[cruisecontrol] 1.7-SNAPSHOT not using correct ${url} for CVS

[Eric Pugh <ep...@opensourceconnections.com>]

Vincent,

I think that the change you made fro using the computed ${url} from
maven-scm-plugin isn't quite right, but I thought I would run it by you.

At least for CVS, I find that the ${url} property is only used to define
the cvsroot.  Therefore it should be ${url} should equal ${root}, and
not have the module appended.  

I haven't committed the change as I thought I would run it by you'all
first..  Am I just attempting to use 1.7-SNAPSHOT in the middle of your
efforts?

If your changes are done, I'd like to move to releasing 1.7 soon, as it
does match to CC 2.2.1 much better.

Eric


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

RE: [cruisecontrol] 1.7-SNAPSHOT not using correct ${url} for CVS

[Vincent Massol <vm...@pivolis.com>]

Hi Eric,

Thanks for the patch you've just committed. You're right, it should be
tested more before committing (I have tested it well with SVN but I have not
tested it with CVS - I had forgotten about this part when I proposed to
release it).

And you're also right that I've not run the plugin tests as they were not
running before I initially started modifying the plugin. I should have spent
time fixing them.

Anyway, let's fix them now.

Thanks
-Vincent

> -----Original Message-----
> From: Eric Pugh [mailto:epugh@opensourceconnections.com]
> Sent: mardi 8 mars 2005 18:19
> To: Maven-Dev
> Subject: [cruisecontrol] 1.7-SNAPSHOT not using correct ${url} for CVS
> 
> Vincent,
> 
> I think that the change you made fro using the computed ${url} from
> maven-scm-plugin isn't quite right, but I thought I would run it by you.
> 
> At least for CVS, I find that the ${url} property is only used to define
> the cvsroot.  Therefore it should be ${url} should equal ${root}, and
> not have the module appended.
> 
> I haven't committed the change as I thought I would run it by you'all
> first..  Am I just attempting to use 1.7-SNAPSHOT in the middle of your
> efforts?
> 
> If your changes are done, I'd like to move to releasing 1.7 soon, as it
> does match to CC 2.2.1 much better.
> 
> Eric
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org