You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/05 21:22:10 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9093:
[fix] Temporary filename for CSV upload to Hive
john-bodley opened a new pull request #9093: [fix] Temporary filename for CSV upload to Hive
URL: https://github.com/apache/incubator-superset/pull/9093
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This PR fixes a regression introduced in https://github.com/apache/incubator-superset/pull/9047 where the Hive CSV upload functionality wasn't updated to leverage temporary file logic. The `filename` is an absolute path (with the `config["UPLOAD_FOLDER"]` prefix and contains a secure file name) and thus there's no need to prefix it again.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Tested locally and confirmed the upload succeeded.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @dpgaspar @michellethomas @robdiciuccio
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9093: [fix]
Temporary filename for CSV upload to Hive
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9093: [fix] Temporary filename for CSV upload to Hive
URL: https://github.com/apache/incubator-superset/pull/9093#issuecomment-582627654
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=h1) Report
> Merging [#9093](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916d184076f39c83c7a9f96de7ab8653955d5238?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9093 +/- ##
==========================================
- Coverage 59.15% 59.13% -0.03%
==========================================
Files 370 372 +2
Lines 11818 11914 +96
Branches 2900 2918 +18
==========================================
+ Hits 6991 7045 +54
- Misses 4648 4687 +39
- Partials 179 182 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set/assets/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `31.72% <0%> (-9.24%)` | :arrow_down: |
| [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `43.24% <0%> (-4.71%)` | :arrow_down: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `41.79% <0%> (-0.28%)` | :arrow_down: |
| [...t/assets/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aWV3cy9kYXNoYm9hcmRMaXN0L0Rhc2hib2FyZExpc3QudHN4) | `73.14% <0%> (-0.25%)` | :arrow_down: |
| [...ssets/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRIZWFkZXIuanN4) | `100% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0FwcC5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/logger/LogUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9sb2dnZXIvTG9nVXRpbHMuanM=) | `100% <0%> (ø)` | :arrow_up: |
| [...set/assets/src/dashboard/util/setPeriodicRunner.js](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9zZXRQZXJpb2RpY1J1bm5lci5qcw==) | `66.66% <0%> (ø)` | |
| [superset/assets/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9093/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aWV3cy9jaGFydExpc3QvQ2hhcnRMaXN0LnRzeA==) | `74.74% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=footer). Last update [916d184...3445b2d](https://codecov.io/gh/apache/incubator-superset/pull/9093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9093: [fix]
Temporary filename for CSV upload to Hive
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9093: [fix] Temporary filename for CSV upload to Hive
URL: https://github.com/apache/incubator-superset/pull/9093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org