You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekagarwal87 (via GitHub)" <gi...@apache.org> on 2023/02/16 05:29:27 UTC
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13782: Use K3S instead of minikube for integration tests
abhishekagarwal87 commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1108031016
##########
integration-tests/script/setup_k8s_cluster.sh:
##########
@@ -16,19 +16,13 @@
set -e
-# Set Necessary ENV
-export CHANGE_MINIKUBE_NONE_USER=true
-export MINIKUBE_WANTUPDATENOTIFICATION=false
-export MINIKUBE_WANTREPORTERRORPROMPT=false
-export MINIKUBE_HOME=$HOME
+export INSTALL_K3S_VERSION=v1.21.14+k3s1
export KUBECONFIG=$HOME/.kube/config
-sudo apt install -y conntrack
-
-# Lacunch K8S cluster
+# Launch K8S cluster
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.18.1/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
-curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.8.1/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
-sudo /usr/local/bin/minikube start --profile=minikube --vm-driver=none --kubernetes-version=v1.18.1
-sudo /usr/local/bin/minikube update-context
-
+curl -sfL https://get.k3s.io | bash /dev/stdin --docker
Review Comment:
there is only one test. It seems that GHA runners have minikube installed but I was told that there were some errors. @tejaswini-imply knows what those errors were.
I tried K3S and I felt that it's really lightweight to download and bring up. CI systems is one of the core use cases for K3S.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org