[GitHub] [kafka] clolov commented on a diff in pull request #13200: MINOR: Move `__consumer_offsets` records from `core` to `group-coordinator`

["clolov (via GitHub)" <gi...@apache.org>]

clolov commented on code in PR #13200:
URL: https://github.com/apache/kafka/pull/13200#discussion_r1097379412


##########
checkstyle/import-control.xml:
##########
@@ -341,7 +341,9 @@
   <subpackage name="coordinator">
     <subpackage name="group">
       <allow pkg="org.apache.kafka.common.message" />
+      <allow pkg="org.apache.kafka.common.protocol" />

Review Comment:
   For my curiosity, are these lines needed in the context of this pull request or they are a remnant from a previous change?



##########
build.gradle:
##########
@@ -1266,6 +1272,23 @@ project(':group-coordinator') {
   javadoc {
     enabled = false
   }
+
+  task processMessages(type:JavaExec) {
+    mainClass = "org.apache.kafka.message.MessageGenerator"
+    classpath = configurations.generator
+    args = [ "-p", "org.apache.kafka.coordinator.group.generated",

Review Comment:
   I noticed that sometimes we append `.generated` in similar closures and sometimes we do not. Are we appending `.generated` going forward?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org