[GitHub] [pinot] jadami10 commented on a change in pull request #8445: add metric for largest segment size

[GitBox <gi...@apache.org>]

jadami10 commented on a change in pull request #8445:
URL: https://github.com/apache/pinot/pull/8445#discussion_r840674870



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java
##########
@@ -99,6 +99,13 @@ public TableSizeDetails getTableSizeDetails(@Nonnull String tableName, @Nonnegat
       _controllerMetrics.setValueOfTableGauge(realtimeTableName, ControllerGauge.TABLE_SIZE_PER_REPLICA_ON_SERVER,
           tableSizeDetails._realtimeSegments._estimatedSizeInBytes / _helixResourceManager.getNumReplicas(
               realtimeTableConfig));
+
+      tableSizeDetails._realtimeSegments._segments.values().stream()

Review comment:
       that's fair, it was just as tedious to write as it is to read. I factored out the "default" size we see when segments are missing into a variable and rewrote it with regular APIs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org