You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ning Zhang (JIRA)" <ji...@apache.org> on 2011/02/01 01:09:29 UTC
[jira] Created: (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
DDLSemanticAnalyzer won't take newly set Hive parameters
--------------------------------------------------------
Key: HIVE-1937
URL: https://issues.apache.org/jira/browse/HIVE-1937
Project: Hive
Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989000#comment-12989000 ]
Carl Steinbach commented on HIVE-1937:
--------------------------------------
@Ning: can you also make TokenToTypeName private? I can't see any reason why this should be public. Thanks!
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-1937:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
committed! thanks Ning
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-1937:
-----------------------------
Attachment: HIVE-1937.2.patch
Good catch Carl. Yeah, it won't work for HiveServer.
I'm uploading a new patch taking your 2 comments.
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1937:
---------------------------------
Component/s: Query Processor
Fix Version/s: 0.8.0
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Fix For: 0.8.0
>
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031031#comment-13031031 ]
jiraposter@reviews.apache.org commented on HIVE-1937:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/707/
-----------------------------------------------------------
Review request for hive.
Summary
-------
this patch resets reservedPartitioinValues every time DDLSemanticAnalyzer got initialized.
This addresses bug HIVE-1937.
https://issues.apache.org/jira/browse/HIVE-1937
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1101312
trunk/ql/src/test/queries/clientnegative/default_partition_name.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/default_partition_name.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/default_partition_name.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/default_partition_name.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/707/diff
Testing
-------
Thanks,
Ning
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1937:
---------------------------------
Status: Open (was: Patch Available)
The proposed solution introduces a concurrency bug since
reservedPartitionValues is a class variable and access to
it is not synchronized. It looks like another solution which
doesn't introduce concurrency issues is to make
make reservedPartitionValues a private instance variable.
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031265#comment-13031265 ]
He Yongqiang commented on HIVE-1937:
------------------------------------
+1, will commit after tests pass
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-1937:
-----------------------------
Attachment: HIVE-1937.patch
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032614#comment-13032614 ]
Hudson commented on HIVE-1937:
------------------------------
Integrated in Hive-trunk-h0.20 #726 (See [https://builds.apache.org/hudson/job/Hive-trunk-h0.20/726/])
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-1937:
-----------------------------
Status: Patch Available (was: Open)
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-1937:
-----------------------------
Status: Patch Available (was: Open)
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-1937) DDLSemanticAnalyzer won't take newly
set Hive parameters
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-1937:
-----------------------------
Attachment: HIVE-1937.3.patch
updated to current trunk.
> DDLSemanticAnalyzer won't take newly set Hive parameters
> --------------------------------------------------------
>
> Key: HIVE-1937
> URL: https://issues.apache.org/jira/browse/HIVE-1937
> Project: Hive
> Issue Type: Bug
> Reporter: Ning Zhang
> Assignee: Ning Zhang
> Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch
>
>
> Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose values come from several Hive parameters. However even if these parameters are set to new values, the reservedPartitionValue are not changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira