You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Darren Shepherd <da...@gmail.com> on 2013/09/18 02:00:11 UTC

Review Request 14189: UserVmDomRInvestigator and ManagementIPSystemVMInvestigator mask adapter name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14189/
-----------------------------------------------------------

Review request for cloudstack, Alex Huang and Kelven Yang.


Repository: cloudstack-git


Description
-------

UserVmDomRInvestigator and ManagementIPSystemVMInvestigator mask _name from ComponentLifeCycleBase making set/getName() not work as expected


Diffs
-----

  server/src/com/cloud/ha/ManagementIPSystemVMInvestigator.java 2b6d261 
  server/src/com/cloud/ha/UserVmDomRInvestigator.java 195deff 

Diff: https://reviews.apache.org/r/14189/diff/


Testing
-------


Thanks,

Darren Shepherd


Re: Review Request 14189: UserVmDomRInvestigator and ManagementIPSystemVMInvestigator mask adapter name

Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14189/#review26250
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On Sept. 18, 2013, midnight, Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14189/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, midnight)
> 
> 
> Review request for cloudstack, Alex Huang and Kelven Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> UserVmDomRInvestigator and ManagementIPSystemVMInvestigator mask _name from ComponentLifeCycleBase making set/getName() not work as expected
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/ha/ManagementIPSystemVMInvestigator.java 2b6d261 
>   server/src/com/cloud/ha/UserVmDomRInvestigator.java 195deff 
> 
> Diff: https://reviews.apache.org/r/14189/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>