You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/05/05 15:50:59 UTC
[GitHub] [accumulo-website] Akshit6828 opened a new pull request #281: Added 'Akshit Mangotra' in people.md
Akshit6828 opened a new pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281
https://github.com/apache/accumulo/pull/2080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] EdColeman merged pull request #281: Added 'Akshit Mangotra' in people.md
Posted by GitBox <gi...@apache.org>.
EdColeman merged pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] Akshit6828 commented on a change in pull request #281: Added 'Akshit Mangotra' in people.md
Posted by GitBox <gi...@apache.org>.
Akshit6828 commented on a change in pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281#discussion_r626726798
##########
File path: CONTRIBUTING.md
##########
@@ -8,7 +8,7 @@ the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing, software
+Unless required by applicable law or agreed to in writing, softwares
Review comment:
Oops! Sorry @EdColeman, sorry my bad. I didn't do that intentionally as I was just going through the Contributing.md in vs code and it might have pressed some key. I am sorry for this change. I'll revert is ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] EdColeman commented on a change in pull request #281: Added 'Akshit Mangotra' in people.md
Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281#discussion_r626718474
##########
File path: CONTRIBUTING.md
##########
@@ -8,7 +8,7 @@ the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing, software
+Unless required by applicable law or agreed to in writing, softwares
Review comment:
Please revert this change.
1) The plural form of software is software - so the original is correct.
2) This is boilerplate from the ASF, if it would need to be changed it should be done at the ASF level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] Akshit6828 commented on a change in pull request #281: Added 'Akshit Mangotra' in people.md
Posted by GitBox <gi...@apache.org>.
Akshit6828 commented on a change in pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281#discussion_r626726798
##########
File path: CONTRIBUTING.md
##########
@@ -8,7 +8,7 @@ the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing, software
+Unless required by applicable law or agreed to in writing, softwares
Review comment:
Oops! Sorry @EdColeman, My bad. I'll revert is ASAP. I won't do that mistake again.
I was not an expert at GitHub so, I was trying to generate a new PR as I wanted to check whether the commit would go to new PR or the same.
And accidentally I committed the changes into the same PR. So sorry for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] Akshit6828 commented on a change in pull request #281: Added 'Akshit Mangotra' in people.md
Posted by GitBox <gi...@apache.org>.
Akshit6828 commented on a change in pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281#discussion_r626726798
##########
File path: CONTRIBUTING.md
##########
@@ -8,7 +8,7 @@ the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing, software
+Unless required by applicable law or agreed to in writing, softwares
Review comment:
Oops! Sorry @EdColeman, sorry my bad. I didn't do that intentionally as I was just going through the readme in vs code and it might have pressed some key. I am sorry for this change. I'll revert is ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] Akshit6828 commented on a change in pull request #281: Added 'Akshit Mangotra' in people.md
Posted by GitBox <gi...@apache.org>.
Akshit6828 commented on a change in pull request #281:
URL: https://github.com/apache/accumulo-website/pull/281#discussion_r626726798
##########
File path: CONTRIBUTING.md
##########
@@ -8,7 +8,7 @@ the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing, software
+Unless required by applicable law or agreed to in writing, softwares
Review comment:
Oops! Sorry @EdColeman, sorry my bad. I'll revert is ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org