You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Sylvain Wallez <sy...@apache.org> on 2004/06/04 15:14:07 UTC
Removing sitemap's check-reload attribute
Working on the TreeProcessor, I noticed "check-reload" that exists on
<map:mount> whose existence I nearly forgot about, and was wondering
about its actual usefulness, furthermore considering that it defaults to
true (i.e. reload when needed)
There are lots and lots of places in Cocoon where automatic reload
occurs with no way to disable it: XSLT, XSP, JXTG, CForms to name a few.
So I propose to remove this "feature", and have automatic sitemap reload
always be turned on, as everywhere else.
WDYT?
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Re: Removing sitemap's check-reload attribute
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Sylvain Wallez wrote:
> Working on the TreeProcessor, I noticed "check-reload" that exists on
> <map:mount> whose existence I nearly forgot about, and was wondering
> about its actual usefulness, furthermore considering that it defaults
> to true (i.e. reload when needed)
>
> There are lots and lots of places in Cocoon where automatic reload
> occurs with no way to disable it: XSLT, XSP, JXTG, CForms to name a few.
Actually, you can turn off XSP reloading.
PS -1 on removing in cocoon.xconf, 0 on removing in map:mount
Vadim
Re: Removing sitemap's check-reload attribute
Posted by Ugo Cei <u....@cbim.it>.
Sylvain Wallez wrote:
> So I propose to remove this "feature", and have automatic sitemap reload
> always be turned on, as everywhere else.
>
> WDYT?
+1
Ugo
Re: Removing sitemap's check-reload attribute
Posted by Joerg Heinicke <jo...@gmx.de>.
On 04.06.2004 15:14, Sylvain Wallez wrote:
> Working on the TreeProcessor, I noticed "check-reload" that exists on
> <map:mount> whose existence I nearly forgot about, and was wondering
> about its actual usefulness, furthermore considering that it defaults to
> true (i.e. reload when needed)
>
> There are lots and lots of places in Cocoon where automatic reload
> occurs with no way to disable it: XSLT, XSP, JXTG, CForms to name a few.
>
> So I propose to remove this "feature", and have automatic sitemap reload
> always be turned on, as everywhere else.
>
> WDYT?
+1 I never switched it off.
IIRC there is also such a setting in cocoon.xconf for the root sitemap.
Does it make sense to switch reload on or off for each subsitemap
individually or is the one setting in cocoon.xconf satisfying enough for
all sitemaps?
Joerg
Re: Removing sitemap's check-reload attribute
Posted by Sylvain Wallez <sy...@apache.org>.
Stefano Mazzocchi wrote:
> Sylvain Wallez wrote:
>
>> Working on the TreeProcessor, I noticed "check-reload" that exists on
>> <map:mount> whose existence I nearly forgot about, and was wondering
>> about its actual usefulness, furthermore considering that it defaults
>> to true (i.e. reload when needed)
>>
>> There are lots and lots of places in Cocoon where automatic reload
>> occurs with no way to disable it: XSLT, XSP, JXTG, CForms to name a few.
>>
>> So I propose to remove this "feature", and have automatic sitemap
>> reload always be turned on, as everywhere else.
>>
>> WDYT?
>
>
> I like the fact that auto-reloading should be consistent and global,
> but I would also like to have the ability to turn it off, especially
> in production environments because this removes some performance
> overhead in the checking (even if it's asynchronous).
>
> Comments?
There were some talks related to this when we discussed store cleanup,
as reload is often related to "compiling" the contents of a Source (e.g.
building a TreeProcessor, a form definition, a stylesheet, etc) and
caching that compiled form for later use. Caching also possibly meaning
purging no more used entries, contrarily to what happens today with
private Maps to store these objects.
There's an initial attempt at this in the scratchpad (util.SourceCache)
which we may build upon.
That may also be a service provided at a lower level by SourceUtil (but
then relying on an ugly static setting) or by the SourceResolver itself.
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Re: Removing sitemap's check-reload attribute
Posted by Stefano Mazzocchi <st...@apache.org>.
Sylvain Wallez wrote:
> Working on the TreeProcessor, I noticed "check-reload" that exists on
> <map:mount> whose existence I nearly forgot about, and was wondering
> about its actual usefulness, furthermore considering that it defaults to
> true (i.e. reload when needed)
>
> There are lots and lots of places in Cocoon where automatic reload
> occurs with no way to disable it: XSLT, XSP, JXTG, CForms to name a few.
>
> So I propose to remove this "feature", and have automatic sitemap reload
> always be turned on, as everywhere else.
>
> WDYT?
I like the fact that auto-reloading should be consistent and global, but
I would also like to have the ability to turn it off, especially in
production environments because this removes some performance overhead
in the checking (even if it's asynchronous).
Comments?
--
Stefano.
Re: Removing sitemaps check-reload attribute
Posted by Antonio Gallardo <ag...@agssa.net>.
Sylvain Wallez dijo:
> Carsten Ziegeler wrote:
>
>>-1 :) Turning off this checking improves performance (no time stamp
>> checking anymore).
>
> Do you think there's a real difference if the sitemap is checked _at
> most_ once per second (the default delay), when so much other files are
> checked at _every_ request?
Instead of removing it. Let move it to other location and add the support
for the other places you posted above. Then we can have a global parameter
in cocoon.xconf that will allow switch to a "production" mode by disabling
all this checks at once.
WDYT?
Best Regards,
Antonio Gallardo
RE: Removing sitemaps check-reload attribute
Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Sylvain Wallez wrote:
>
> Carsten Ziegeler wrote:
>
> >-1 :) Turning off this checking improves performance (no
> time stamp checking anymore).
> >
> >
>
> Do you think there's a real difference if the sitemap is
> checked _at most_ once per second (the default delay), when
> so much other files are checked at _every_ request?
>
This depends on your setup, you can e.g. use expires caching
where the files are not checked at every request or you
can use custom components that have a smarter check etc.
So, yes, I think there is a major difference.
Carsten
Re: Removing sitemaps check-reload attribute
Posted by Sylvain Wallez <sy...@apache.org>.
Carsten Ziegeler wrote:
>-1 :) Turning off this checking improves performance (no time stamp checking anymore).
>
>
Do you think there's a real difference if the sitemap is checked _at
most_ once per second (the default delay), when so much other files are
checked at _every_ request?
Sylvain
>>-----Original Message-----
>>From: Sylvain Wallez [mailto:sylvain@apache.org]
>>Sent: Friday, June 04, 2004 3:14 PM
>>To: cocoon-dev
>>Subject: Removing sitemaps check-reload attribute
>>
>>Working on the TreeProcessor, I noticed "check-reload" that
>>exists on <map:mount> whose existence I nearly forgot about,
>>and was wondering about its actual usefulness, furthermore
>>considering that it defaults to true (i.e. reload when needed)
>>
>>There are lots and lots of places in Cocoon where automatic
>>reload occurs with no way to disable it: XSLT, XSP, JXTG,
>>CForms to name a few.
>>
>>So I propose to remove this "feature", and have automatic
>>sitemap reload always be turned on, as everywhere else.
>>
>>WDYT?
>>
>>Sylvain
>>
>>
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Re: Removing sitemaps check-reload attribute
Posted by Sylvain Wallez <sy...@apache.org>.
Carsten Ziegeler wrote:
>Forgot to add:
>
>The default is "true" anyways, so you can just ignore this feature. But it might be useful for people that want to fine tune their setup. So in the end it doesn't hurt if you have the possibility.
>
>
Sure, and I won't insist much for this reason. I just find this feature
rather useless and inconsistent with Cocoon's general behaviour.
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
RE: Removing sitemaps check-reload attribute
Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Forgot to add:
The default is "true" anyways, so you can just ignore this feature.
But it might be useful for people that want to fine tune their
setup. So in the end it doesn't hurt if you have the possibility.
Carsten
> -----Original Message-----
> From: Carsten Ziegeler [mailto:cziegeler@s-und-n.de]
> Sent: Friday, June 04, 2004 3:20 PM
> To: dev@cocoon.apache.org
> Subject: RE: Removing sitemaps check-reload attribute
>
> -1 :) Turning off this checking improves performance (no time
> stamp checking anymore).
>
> Carsten
>
> > -----Original Message-----
> > From: Sylvain Wallez [mailto:sylvain@apache.org]
> > Sent: Friday, June 04, 2004 3:14 PM
> > To: cocoon-dev
> > Subject: Removing sitemaps check-reload attribute
> >
> > Working on the TreeProcessor, I noticed "check-reload" that
> exists on
> > <map:mount> whose existence I nearly forgot about, and was
> wondering
> > about its actual usefulness, furthermore considering that
> it defaults
> > to true (i.e. reload when needed)
> >
> > There are lots and lots of places in Cocoon where automatic reload
> > occurs with no way to disable it: XSLT, XSP, JXTG, CForms to name a
> > few.
> >
> > So I propose to remove this "feature", and have automatic sitemap
> > reload always be turned on, as everywhere else.
> >
> > WDYT?
> >
> > Sylvain
> >
> > --
> > Sylvain Wallez Anyware Technologies
> > http://www.apache.org/~sylvain http://www.anyware-tech.com
> > { XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
> >
> >
>
RE: Removing sitemaps check-reload attribute
Posted by Carsten Ziegeler <cz...@s-und-n.de>.
-1 :) Turning off this checking improves performance (no time
stamp checking anymore).
Carsten
> -----Original Message-----
> From: Sylvain Wallez [mailto:sylvain@apache.org]
> Sent: Friday, June 04, 2004 3:14 PM
> To: cocoon-dev
> Subject: Removing sitemaps check-reload attribute
>
> Working on the TreeProcessor, I noticed "check-reload" that
> exists on <map:mount> whose existence I nearly forgot about,
> and was wondering about its actual usefulness, furthermore
> considering that it defaults to true (i.e. reload when needed)
>
> There are lots and lots of places in Cocoon where automatic
> reload occurs with no way to disable it: XSLT, XSP, JXTG,
> CForms to name a few.
>
> So I propose to remove this "feature", and have automatic
> sitemap reload always be turned on, as everywhere else.
>
> WDYT?
>
> Sylvain
>
> --
> Sylvain Wallez Anyware Technologies
> http://www.apache.org/~sylvain http://www.anyware-tech.com
> { XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
>
>