You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/08/11 11:35:14 UTC
[GitHub] [incubator-teaclave-sgx-sdk] PiDelport opened a new pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
PiDelport opened a new pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352
Without this fix, the timestamp of `config.h.in~` invalidates the cargo build whenever alternating between the `dev` and `release` profiles. This can be reproduced by repeatedly building `sgx_unwind` with the following invocation:
```
$ cargo build; cargo build --release
Compiling sgx_unwind v0.1.1 (…/incubator-teaclave-sgx-sdk/sgx_unwind)
Finished dev [unoptimized + debuginfo] target(s) in 22.34s
Compiling sgx_unwind v0.1.1 (…/incubator-teaclave-sgx-sdk/sgx_unwind)
Finished release [optimized] target(s) in 21.65s
```
With this fix, once they're built, subsequent invocations don't rebuild them:
```
$ cargo build; cargo build --release
Finished dev [unoptimized + debuginfo] target(s) in 0.01s
Finished release [optimized] target(s) in 0.01s
```
Note that this issue doesn't seem to occur when repeatedly building just a single profile (presumably because that avoids re-invoking the configure script?), but it significantly impacts the interactive development experience for SGX projects that build both `dev` and `release` targets as part of the same build: this makes the difference between rebuilds being nearly instantaneous, or always taking a minute or so for `sgx_unwind` to rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
volcano0dr commented on pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352#issuecomment-897296215
Thank you for fixing this issue!
Please help fix the build script in sgx_no_tstd. I will merge this PR after the repair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] PiDelport commented on pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
PiDelport commented on pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352#issuecomment-912796169
> Yes, the same changes need to be applied to sgx_no_tstd/build.rs.
@volcano0dr: Applied.
(Thank you for being patient with the delay!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr removed a comment on pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
volcano0dr removed a comment on pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352#issuecomment-897571871
> @volcano0dr: So does this just need the same change applied to `sgx_no_tstd/build.rs`, in addition to the current change?
@PiDelport: Yes, the same changes need to be applied to `sgx_no_tstd/build.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] PiDelport commented on pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
PiDelport commented on pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352#issuecomment-897516606
@volcano0dr: So does this just need the same change applied to `sgx_no_tstd/build.rs`, in addition to the current change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr merged pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
volcano0dr merged pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
volcano0dr commented on pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352#issuecomment-897572239
> @volcano0dr: So does this just need the same change applied to `sgx_no_tstd/build.rs`, in addition to the current change?
@PiDelport Yes, the same changes need to be applied to sgx_no_tstd/build.rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on pull request #352: build(sgx_unwind): ignore "config.h.in~" to avoid unnecessary rebuilds
Posted by GitBox <gi...@apache.org>.
volcano0dr commented on pull request #352:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/352#issuecomment-897571871
> @volcano0dr: So does this just need the same change applied to `sgx_no_tstd/build.rs`, in addition to the current change?
@PiDelport: Yes, the same changes need to be applied to `sgx_no_tstd/build.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org