You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/08/05 12:31:33 UTC

[GitHub] [brooklyn-ui] ahgittin commented on pull request #261: Fixed Composer required label check

ahgittin commented on pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261#issuecomment-893420836


   aha this is part of the fix -- `parameter` uses `default` -- however _config_ key definitions use `defaultValue` so this will break for defaults coming from the server-side model (eg parent class).  and there are other places we use `defaultValue` where we should be checking both `defaultValue` and `default`.  will open follow-on PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org