[PATCH] Follow up for r18146.

[Madan U Sreenivasan <ma...@collab.net>]

Hi,

   I found a minor bug while looking at r18146. Pl. find patch attached to  
fix this.

[[[
Follow-up for r18146.

* subversion/libsvn_repos/hooks.c:
   (run_hook_cmd): Actually capture the return value of
    apr_file_inherit_unset() before testing for error.
]]]

Regards,
Madan.

Re: [PATCH] Follow up for r18146.

[Daniel Rall <dl...@collab.net>]

On Tue, 18 Jul 2006, Garrett Rooney wrote:

> On 7/18/06, Madan U Sreenivasan <ma...@collab.net> wrote:
> >Hi,
> >
> >   I found a minor bug while looking at r18146. Pl. find patch attached to
> >fix this.
> >
> >[[[
> >Follow-up for r18146.
> >
> >* subversion/libsvn_repos/hooks.c:
                                    ^
                      Drop that character.

> >   (run_hook_cmd): Actually capture the return value of
> >    apr_file_inherit_unset() before testing for error.
> >]]]
> 
> Looks fine to me, +1 to commit.

+1 to commit -- list rooneg and I in the "Approved by" field of your
log message.  Please also propose this for backport to 1.4.x and list
me as a +1.

This is edge case-y enough that it should not be considered a blocker
for the 1.4.0 release.

- Dan

Re: [PATCH] Follow up for r18146.

[Garrett Rooney <ro...@electricjellyfish.net>]

On 7/18/06, Madan U Sreenivasan <ma...@collab.net> wrote:
> Hi,
>
>    I found a minor bug while looking at r18146. Pl. find patch attached to
> fix this.
>
> [[[
> Follow-up for r18146.
>
> * subversion/libsvn_repos/hooks.c:
>    (run_hook_cmd): Actually capture the return value of
>     apr_file_inherit_unset() before testing for error.
> ]]]

Looks fine to me, +1 to commit.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org