You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/08/22 18:38:42 UTC

[GitHub] beam pull request #3745: [BEAM-2791] Add a test for an event time timer loop...

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3745

    [BEAM-2791] Add a test for an event time timer loop in ParDo

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @tgroh adding this test to indicate the issue and link with JIRA, and will try to find time to fix it later.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam timer-loop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3745
    
----
commit 2a4d086c9e41b1bfcc495a166dac43e68bb82dbe
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-08-22T18:34:59Z

    Add a test for an event time timer loop in ParDo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---