[GitHub] [datasketches-memory] davecromberge commented on a diff in pull request #164: Move java8test to java8

[GitBox <gi...@apache.org>]

davecromberge commented on code in PR #164:
URL: https://github.com/apache/datasketches-memory/pull/164#discussion_r918323574


##########
tools/scripts/getGitProperties.sh:
##########
@@ -38,28 +38,28 @@ tmp='org.apache.datasketches:'$ArtId$CR
 prop=$prop$tmp
 
 # Add Branch
-prop=$prop'git.branch: '
+prop=$prop'Git-Branch: '
 tmp=''$(git rev-parse --abbrev-ref HEAD)''$CR
 prop=$prop$tmp
 
 #Add commit-id
-prop=$prop'git.commit.id.full: '
+prop=$prop'Git-Commit-Id-Full: '
 ID=$(git rev-parse HEAD)
 tmp=''$ID''$CR
 prop=$prop$tmp
 
 #Add timestamp
-prop=$prop'git.commit.time: '
+prop=$prop'Git-Commit-Time: '
 tmp=''$(git show --no-patch --no-notes --pretty='%cI' $ID)''$CR
 prop=$prop$tmp
 
 #Add user email
-prop=$prop'git-commit-user-email: '
+prop=$prop'Git-Commit-User-Email: '
 tmp=''$(git show --no-patch --no-notes --pretty='%ce' $ID)''$CR
 prop=$prop$tmp
 
 #Add Tag
-prop=$prop'git.commit.tag: '
+prop=$prop'Git-Commit-Tag: '

Review Comment:
   @leerho these changes fail the JAR validation for valid manifest properties.  Once this PR is merged, the equivalent changes can be made to the release script in svn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org