You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Paul Chavez <pc...@verticalsearchworks.com> on 2013/04/18 18:35:52 UTC
Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/
-----------------------------------------------------------
Review request for Flume.
Description
-------
After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
This addresses bug FLUME-1993.
https://issues.apache.org/jira/browse/FLUME-1993
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
Diff: https://reviews.apache.org/r/10607/diff/
Testing
-------
Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
Thanks,
Paul Chavez
Re: Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
Posted by Paul Chavez <pc...@verticalsearchworks.com>.
> On April 18, 2013, 8:05 p.m., Mike Percy wrote:
> > Hi Paul, please attach the latest version of your patch to the JIRA.
> >
> > Thanks,
> > Mike
Current version on the JIRA issue (timestamp 18/Apr/13 09:37) is the latest.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/#review19405
-----------------------------------------------------------
On April 18, 2013, 4:35 p.m., Paul Chavez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10607/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 4:35 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
>
>
> This addresses bug FLUME-1993.
> https://issues.apache.org/jira/browse/FLUME-1993
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
>
> Diff: https://reviews.apache.org/r/10607/diff/
>
>
> Testing
> -------
>
> Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
>
>
> Thanks,
>
> Paul Chavez
>
>
Re: Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/#review19405
-----------------------------------------------------------
Hi Paul, please attach the latest version of your patch to the JIRA.
Thanks,
Mike
- Mike Percy
On April 18, 2013, 4:35 p.m., Paul Chavez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10607/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 4:35 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
>
>
> This addresses bug FLUME-1993.
> https://issues.apache.org/jira/browse/FLUME-1993
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
>
> Diff: https://reviews.apache.org/r/10607/diff/
>
>
> Testing
> -------
>
> Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
>
>
> Thanks,
>
> Paul Chavez
>
>
Re: Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/#review19439
-----------------------------------------------------------
Ship it!
Good catch.
- Alexander Alten-Lorenz
On April 18, 2013, 4:35 p.m., Paul Chavez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10607/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 4:35 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
>
>
> This addresses bug FLUME-1993.
> https://issues.apache.org/jira/browse/FLUME-1993
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
>
> Diff: https://reviews.apache.org/r/10607/diff/
>
>
> Testing
> -------
>
> Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
>
>
> Thanks,
>
> Paul Chavez
>
>
Re: Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/#review19403
-----------------------------------------------------------
Ship it!
+1
- Mike Percy
On April 18, 2013, 4:35 p.m., Paul Chavez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10607/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 4:35 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
>
>
> This addresses bug FLUME-1993.
> https://issues.apache.org/jira/browse/FLUME-1993
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
>
> Diff: https://reviews.apache.org/r/10607/diff/
>
>
> Testing
> -------
>
> Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
>
>
> Thanks,
>
> Paul Chavez
>
>
Re: Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
Posted by Phil Scala <ph...@globalrelay.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/#review19432
-----------------------------------------------------------
Ship it!
I am comfortable with the change
- Phil Scala
On April 18, 2013, 4:35 p.m., Paul Chavez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10607/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 4:35 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
>
>
> This addresses bug FLUME-1993.
> https://issues.apache.org/jira/browse/FLUME-1993
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
>
> Diff: https://reviews.apache.org/r/10607/diff/
>
>
> Testing
> -------
>
> Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
>
>
> Thanks,
>
> Paul Chavez
>
>
Re: Review Request: Fix for issue FLUME-1993,
access violation in Windows with spoolDir source.
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10607/#review19442
-----------------------------------------------------------
Thanks guys, I already committed this.
Paul, please close this request by going to Close > Submitted.
- Mike Percy
On April 18, 2013, 4:35 p.m., Paul Chavez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10607/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 4:35 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> After checking that the meta file is tracking the right target, don't create a new instance unless it's needed. Otherwise a new instance is requested while the old one is still open for read/write which triggers access exception in Windows.
>
>
> This addresses bug FLUME-1993.
> https://issues.apache.org/jira/browse/FLUME-1993
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 37f0ee1
>
> Diff: https://reviews.apache.org/r/10607/diff/
>
>
> Testing
> -------
>
> Unit tests not run. Functional testing for this specific issue has been done on Windows Server 2008 R2
>
>
> Thanks,
>
> Paul Chavez
>
>