[PR] refactor(core): drop retired execute permission mode from capability audit [maka]

["yunaremaia (via GitHub)" <gi...@apache.org>]

yunaremaia opened a new pull request, #3603:
URL: https://github.com/apache/maka/pull/3603

   ## Summary
   
   Removes the retired `execute` permission mode from `CAPABILITY_AUDIT_PERMISSION_MODES` and simplifies the capability audit surface, completing the cleanup described in #3385.
   
   ## What changed
   
   - **`CAPABILITY_AUDIT_PERMISSION_MODES`**: removed `execute` — now `[explore, ask]` (matching `PERMISSION_MODES` in `permission.ts`, which already dropped it).
   - **`SkillAuditRecord.permissionMode`**: simplified from `Exclude<CapabilityAuditPermissionMode, 'execute')` to `CapabilityAuditPermissionMode` — the `Exclude` is no longer needed.
   - **`scheduledTaskPermissionMode()`**: active tasks now map to `ask` instead of the retired `execute` (behavioural equivalent; the runtime already folded `execute` → `ask` at all persistence sites).
   - **`executableScheduledTaskCount`**: filters `enabled && permissionMode !== 'explore'` instead of the now-unreachable `permissionMode === 'execute'` literal.
   - **CLI `activation-command.ts`**: retained as-is — the `execute → ask` alias serves external callers and is already documented with an explanatory comment.
   
   ## What this does NOT change
   
   The `execute` mode is already retired from `PERMISSION_MODES`, all persistence decode sites (`decodePersistedPermissionMode` in `permission.ts`), the protocol epoch, and the desktop/CLI UI surfaces. This PR removes the last audit-side reference.
   
   ## Scope note
   
   The `useNewTaskChoice` shadow state and `resolveCreateSessionInput` mentioned in #3385 appear to have been removed in prior work — they no longer exist in the current `main`. The remaining cleanup was the capability audit side handled here.
   
   ## Testing
   
   - Existing tests in `scheduled-task.test.ts`, `tool-result-record-schema.test.ts`, and `tool-result-preview.test.ts` already exercise the retired-mode folding (`execute → ask` on persisted records) and rejection (`execute` on live wire). This refactor does not change that behaviour.
   - CI `typecheck` and `test` will validate; I was unable to run `npm install` locally (blocked by `@xterm/xterm` registry fetch failure on this host) so I did not run the full test suite. This is disclosed transparently.
   
   ## AI disclosure
   
   OpenAI Codex assisted with codebase analysis and this implementation. I reviewed the diff and take responsibility for the contribution.
   
   Signed-off-by: Yunare Maia <yu...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] refactor(core): drop retired execute permission mode from capability audit [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han merged PR #3603:
URL: https://github.com/apache/maka/pull/3603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org