You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/09 00:41:31 UTC

Re: Review Request: Using URIs for the sample frameworks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7182/#review12248
-----------------------------------------------------------

Ship it!


Can we do this for the Java and Python examples too please!?

- Benjamin Hindman


On Sept. 19, 2012, 10:16 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7182/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This ensures the binary gets placed in the work dir rather than running from the build dir.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp e9b60de 
>   src/examples/long_lived_framework.cpp 04ac678 
>   src/examples/test_framework.cpp b9ab692 
> 
> Diff: https://reviews.apache.org/r/7182/diff/
> 
> 
> Testing
> -------
> 
> make check (although, the frameworks hang due to the executor launcher VLOG locking bug, about to be fixed by vinod)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request: Using URIs for the sample frameworks.

Posted by Ben Mahler <be...@gmail.com>.

> On Oct. 8, 2012, 10:41 p.m., Benjamin Hindman wrote:
> > Can we do this for the Java and Python examples too please!?

done, PLEASE READ the note on my upcoming diff!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7182/#review12248
-----------------------------------------------------------


On Sept. 19, 2012, 10:16 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7182/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This ensures the binary gets placed in the work dir rather than running from the build dir.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp e9b60de 
>   src/examples/long_lived_framework.cpp 04ac678 
>   src/examples/test_framework.cpp b9ab692 
> 
> Diff: https://reviews.apache.org/r/7182/diff/
> 
> 
> Testing
> -------
> 
> make check (although, the frameworks hang due to the executor launcher VLOG locking bug, about to be fixed by vinod)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>