You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/13 17:16:36 UTC

[GitHub] [spark] attilapiros commented on issue #24499: [SPARK-27677][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation

attilapiros commented on issue #24499: [SPARK-27677][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation
URL: https://github.com/apache/spark/pull/24499#issuecomment-491910045
 
 
   @squito 
   > Nothing is going to delete the rdd files if you call unpersist after the original executor has already been removed. But was that already true before?
   
   Good catch. I also planed to go through the `unpersist` mechanism because of my other open PR (https://github.com/apache/spark/pull/24554). Yes, this is a change in the behaviour. And I think we should correct this discrepancy as it breaks the symmetry (for existing original executors the file is deleted).
   
   I am checking for possibilities (as I see a new `BlockTransferMessage` have to be introduced for a clean solution) I will come back to you with a commit targeting this problem in the next days.  
   
      

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org