You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/03 07:25:29 UTC

[GitHub] [incubator-devlake] warren830 opened a new pull request, #4083: docs(github): add comment for collector using since

warren830 opened a new pull request, #4083:
URL: https://github.com/apache/incubator-devlake/pull/4083

   ### Summary
   In collectApiPrReviewCommentsMeta and collectApiComments, we are using `since` instead of `created` to collect data created after the given time. This might mislead developers, so we add some annotations.
   Using `since` will return data updated the given time, so the data contains both that updated and created after the given time.
   
   ### Does this close any open issues?
   Relate to #4044 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4083: docs(github): add comment for collector using since

Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #4083:
URL: https://github.com/apache/incubator-devlake/pull/4083#discussion_r1060369550


##########
plugins/github/tasks/pr_review_comment_collector.go:
##########
@@ -57,7 +57,13 @@ func CollectPrReviewComments(taskCtx core.SubTaskContext) errors.Error {
 		Query: func(reqData *helper.RequestData) (url.Values, errors.Error) {
 			query := url.Values{}
 			// if data.CreatedDateAfter != nil, we set since once
+			// Actually we should use create instead of since, but this api only has since as query param

Review Comment:
   Do we still need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4083: docs(github): add comment for collector using since

Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #4083:
URL: https://github.com/apache/incubator-devlake/pull/4083#discussion_r1060342799


##########
plugins/github/tasks/comment_collector.go:
##########
@@ -56,6 +56,9 @@ func CollectApiComments(taskCtx core.SubTaskContext) errors.Error {
 			query.Set("state", "all")
 			// if data.CreatedDateAfter != nil, we set since once
 			if data.CreatedDateAfter != nil {
+				// Actually we should use create instead of since, but this api only has since as query param

Review Comment:
   Note that `since` is for filtering records by the `updated` time which is not ideal for semantic reasons and would result in slightly more records than expected. But we have no choice since it is the only available field we could exploit from the API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4083: docs(github): add comment for collector using since

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #4083:
URL: https://github.com/apache/incubator-devlake/pull/4083#discussion_r1060350654


##########
plugins/github/tasks/comment_collector.go:
##########
@@ -56,6 +56,9 @@ func CollectApiComments(taskCtx core.SubTaskContext) errors.Error {
 			query.Set("state", "all")
 			// if data.CreatedDateAfter != nil, we set since once
 			if data.CreatedDateAfter != nil {
+				// Actually we should use create instead of since, but this api only has since as query param

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #4083: docs(github): add comment for collector using since

Posted by GitBox <gi...@apache.org>.
klesh merged PR #4083:
URL: https://github.com/apache/incubator-devlake/pull/4083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org