You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/07/04 06:28:20 UTC

[GitHub] [lucene-solr] mocobeta opened a new pull request #761: SOLR-13593: Allow to use analyzer SPI names in schema definition.

mocobeta opened a new pull request #761: SOLR-13593: Allow to use analyzer SPI names in schema definition.
URL: https://github.com/apache/lucene-solr/pull/761
 
 
   # Description
   
   Please see the issue description: https://issues.apache.org/jira/browse/SOLR-13593
   
   # Solution
   
   - Allow to load tokenizer/charFilter/tokenFilter factories via SPI name ("spi" attribute) in `FieldTypePluginLoader`. If both two attributes ("class" and "spi") are defined, "class" is preferred.
   - For `add-field-type` REST API, accept a field type definition if either "class" or "spi" property is defined.
   
   # Tests
   
   TBD
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [x] I have developed this patch against the `master` branch.
   - [] I have run `ant precommit` and the appropriate test suite.
   - [] I have added tests for my changes.
   - [] I have added documentation for the Ref Guide (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org