You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/23 10:39:18 UTC
[GitHub] [zookeeper] zengchao1212 commented on pull request #1541: ZOOKEEPER-4004:ZKUtil.visitSubTreeDFSHelper use method with recursive may occur some question
zengchao1212 commented on pull request #1541:
URL: https://github.com/apache/zookeeper/pull/1541#issuecomment-732075386
> * Yes, the original implementation is not the DFS, it's pre-Order-Traverse
> * Using a stack to implement the DFS looks good(avoid StackOverflowException). With this change, the behaviour of the CLI:` ls -R` is similar to `tree `command of linux(lgtm).
> * For the unit case, Could you please add more tests? For example:
>
> * corner case(the root path:/);
> * mixed different level tree path;
> * a very deep/long tree path
I did some tests, it is seem ok, should i commit it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org