You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by rc...@apache.org on 2024/05/15 03:16:57 UTC

(james-project) 02/04: JAMES-3693 Update test method name in RedisRateLimiterWithMasterReplicaTopologyTest

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit a2a21c52caabbc23fb0b2f2524da26898a7dd5a8
Author: hung phan <hp...@linagora.com>
AuthorDate: Mon May 13 15:17:19 2024 +0700

    JAMES-3693 Update test method name in RedisRateLimiterWithMasterReplicaTopologyTest
---
 .../RedisRateLimiterWithMasterReplicaTopologyTest.scala     | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/server/mailet/rate-limiter-redis/src/test/java/org/apache/james/rate/limiter/RedisRateLimiterWithMasterReplicaTopologyTest.scala b/server/mailet/rate-limiter-redis/src/test/java/org/apache/james/rate/limiter/RedisRateLimiterWithMasterReplicaTopologyTest.scala
index 36987d75d7..8f642bb383 100644
--- a/server/mailet/rate-limiter-redis/src/test/java/org/apache/james/rate/limiter/RedisRateLimiterWithMasterReplicaTopologyTest.scala
+++ b/server/mailet/rate-limiter-redis/src/test/java/org/apache/james/rate/limiter/RedisRateLimiterWithMasterReplicaTopologyTest.scala
@@ -28,8 +28,8 @@ import org.apache.james.rate.limiter.RedisRateLimiterWithMasterReplicaTopologyTe
 import org.apache.james.rate.limiter.api.{AcceptableRate, RateLimitingKey, RateLimitingResult, Rule, Rules}
 import org.apache.james.rate.limiter.redis.RedisRateLimiterFactory
 import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
-import org.junit.jupiter.api.{BeforeEach, Test}
 import reactor.core.scala.publisher.SMono
 
 object RedisRateLimiterWithMasterReplicaTopologyTest {
@@ -39,16 +39,9 @@ object RedisRateLimiterWithMasterReplicaTopologyTest {
 
 @ExtendWith(Array(classOf[RedisMasterReplicaExtension]))
 class RedisRateLimiterWithMasterReplicaTopologyTest {
-  var rateLimiterFactory: RedisRateLimiterFactory = _
-
-  @BeforeEach
-  def setup(redisClusterContainer: RedisMasterReplicaContainer): Unit = {
-    rateLimiterFactory = new RedisRateLimiterFactory(redisClusterContainer.getRedisConfiguration)
-  }
-
   @Test
-  def test(redisClusterContainer: RedisMasterReplicaContainer): Unit = {
-    val rateLimiterFactory = new RedisRateLimiterFactory(redisClusterContainer.getRedisConfiguration)
+  def rateLimitShouldWorkNormally(redisClusterContainer: RedisMasterReplicaContainer): Unit = {
+    val rateLimiterFactory: RedisRateLimiterFactory = new RedisRateLimiterFactory(redisClusterContainer.getRedisConfiguration)
     val rateLimiter = rateLimiterFactory.withSpecification(RULES, SLIDING_WIDOW_PRECISION)
     val actual: RateLimitingResult = SMono(rateLimiter.rateLimit(TestKey("key1"), 4)).block()
     assertThat(actual).isEqualTo(AcceptableRate)


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org