You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "Yizhou-Yang (via GitHub)" <gi...@apache.org> on 2023/01/31 07:18:17 UTC
[GitHub] [inlong] Yizhou-Yang commented on a diff in pull request #7287: [INLONG-7286][Sort] Fix issue of tableidentifier being null when addRow
Yizhou-Yang commented on code in PR #7287:
URL: https://github.com/apache/inlong/pull/7287#discussion_r1091534406
##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -441,7 +441,10 @@ private void addBatch(T row) {
@SuppressWarnings({"unchecked"})
private void addRow(RowKind rowKind, JsonNode rootNode, JsonNode physicalNode, JsonNode updateBeforeNode,
- Map<String, String> physicalData, Map<String, String> updateBeforeData) {
+ Map<String, String> physicalData, Map<String, String> updateBeforeData) throws IOException {
+ String tableIdentifier = StringUtils.join(
Review Comment:
it worked in the testing environment. will this introduce new problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org