[GitHub] [spark] viirya edited a comment on pull request #31369: [SPARK-34270][SS] Combine StateStoreMetrics should not override StateStoreCustomMetric

[GitBox <gi...@apache.org>]

viirya edited a comment on pull request #31369:
URL: https://github.com/apache/spark/pull/31369#issuecomment-774639158


   @xuanyuanking Thanks for continuing looking this.
   
   > Here's some analysis:
   The left/rightSideMetrics passed in combine function are objects with adding new descriptions here:
   
   Oh, yeah, looks like `SymmetricHashJoinStateManager.metrics` changes metric description to prevent the metrics to be overridden. However I'd say we still should make `StateStoreMetrics.combine` solid to prevent possible metric overriding as the added test case shows.
   
   > It seems that the overridden shouldn't happen in the original codebase for the custom metrics framework.
   
   It possibly happens. I think we should not rely on the caller of `StateStoreMetrics.combine` to change metric name/description to avoid overridding metrics.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org