You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "platinumhamburg (via GitHub)" <gi...@apache.org> on 2026/09/21 12:09:44 UTC

[PR] [rpc] Reject inactive lazy requests before queuing [fluss]

platinumhamburg opened a new pull request, #4461:
URL: https://github.com/apache/fluss/pull/4461

   ### Purpose
   
   Linked issue: close #4460
   
   Prevent lazily parsed requests from entering `RequestChannel` after their connection becomes inactive, which can leave queued requests backed by a released `ByteBuf`.
   
   ### Brief change log
   
   - Reject inactive requests before queue admission.
   - Add a regression test using `ProduceLogRequest`.
   
   ### Tests
   
   - `./mvnw -pl fluss-server -am -Dtest=NettyServerHandlerProduceLogLifecycleTest -DfailIfNoTests=false test`
   - `./mvnw -pl fluss-rpc -am -Dtest=NettyServerHandlerTest -DfailIfNoTests=false test`
   
   ### API and Format
   
   No API or format changes.
   
   ### Documentation
   
   Not applicable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [rpc] Reject inactive lazy requests before queuing [fluss]

Posted by "platinumhamburg (via GitHub)" <gi...@apache.org>.
platinumhamburg commented on PR #4461:
URL: https://github.com/apache/fluss/pull/4461#issuecomment-5772293396

   Thank you, @chaohaochen, for identifying the original bug and conducting a thorough investigation and in-depth analysis of its contextual details. After attempting my own analysis and reproduction based on your findings, I believe the current issue represents a high-confidence root cause.
   
   Could @chaohaochen, @gyang94, and @swuferhong please take the time to review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [rpc] Reject inactive lazy requests before queuing [fluss]

Posted by "platinumhamburg (via GitHub)" <gi...@apache.org>.
platinumhamburg merged PR #4461:
URL: https://github.com/apache/fluss/pull/4461


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [rpc] Reject inactive lazy requests before queuing [fluss]

Posted by "gyang94 (via GitHub)" <gi...@apache.org>.
gyang94 commented on PR #4461:
URL: https://github.com/apache/fluss/pull/4461#issuecomment-5775954447

   @platinumhamburg LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org