[GitHub] [gobblin] aplex commented on a change in pull request #3353: [GOBBLIN-1507] Prevent orchestrator removals when unscheduling flows

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3353:
URL: https://github.com/apache/gobblin/pull/3353#discussion_r685518098



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -74,8 +61,17 @@
 import org.apache.gobblin.service.monitoring.FlowStatusGenerator;
 import org.apache.gobblin.util.ConfigUtils;
 import org.apache.gobblin.util.PropertiesUtils;
+import org.apache.helix.HelixManager;
+import org.quartz.DisallowConcurrentExecution;
+import org.quartz.InterruptableJob;
+import org.quartz.JobDataMap;
+import org.quartz.JobExecutionContext;
+import org.quartz.JobExecutionException;
+import org.quartz.UnableToInterruptJobException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
-import static org.apache.gobblin.service.ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX;
+import static org.apache.gobblin.service.ServiceConfigKeys.*;

Review comment:
       Wildcard imports are risky - https://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad
   
   The only place were we typically use them is in assertions/mock import, to improve test readability.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org