You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "min-guk (via GitHub)" <gi...@apache.org> on 2024/09/23 13:55:07 UTC
[PR] [SYSTEMDS-3729] Add roll reorg operations in SP [systemds]
min-guk opened a new pull request, #2112:
URL: https://github.com/apache/systemds/pull/2112
This PR implements a new roll reorg function in SP.
- In Javatest, the results of CP and SP are compared to validate the SP implementation.
- To avoid code duplication between CP and SP, a function for copying matrices was created, and both functions now use it.
Please feel free to share any feedback or suggestions regarding the implementation direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3729] Add roll reorg operations in SP [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2112:
URL: https://github.com/apache/systemds/pull/2112#issuecomment-2373319279
LGTM - thanks for the patch @min-guk. During the merge I fixed some remaining warnings (unnecessary imports) and the check for opcodes which made the tests fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3729] Add roll reorg operations in SP [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 closed pull request #2112: [SYSTEMDS-3729] Add roll reorg operations in SP
URL: https://github.com/apache/systemds/pull/2112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org