You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2011/02/09 20:24:57 UTC

[jira] Created: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Test BookieRecoveryTest fails on trunk.
---------------------------------------

                 Key: ZOOKEEPER-985
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
             Project: ZooKeeper
          Issue Type: Bug
          Components: contrib-bookkeeper
         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
            Reporter: Mahadev konar
            Assignee: Flavio Junqueira
             Fix For: 3.4.0


The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992717#comment-12992717 ] 

Flavio Junqueira commented on ZOOKEEPER-985:
--------------------------------------------

Sounds like a race condition. Checking the logs, I found this:

{noformat}
2011-02-09 11:07:39,245 - INFO  - [main:BookieRecoveryTest@165] - New bookie on port 5003 has been created.
2011-02-09 11:07:39,248 - ERROR - [pool-6-thread-1:PerChannelBookieClient$1@129] - Could not connect to bookie: /10.73.146.106:5000
2011-02-09 11:07:39,248 - WARN  - [pool-6-thread-1:PendingAddOp@115] - Write did not succeed: 1, 10
2011-02-09 11:07:39,253 - ERROR - [pool-6-thread-1:LedgerHandle@423] - Could not get additional bookie to remake ensemble, closing ledger: 1
{noformat} 

We are starting a new bookie, but it sounds like we are not giving enough time for the bookie to start up to be incorporated into the ensemble.


> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated ZOOKEEPER-985:
---------------------------------------

    Attachment: ZOOKEEPER-985.patch

I have added some short methods to allow the test to check if a new bookie is running. I haven't been able to reproduce it, but from my understanding from inspecting the logs, it looks like it should solve it. 

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-985:
------------------------------------

    Hadoop Flags: [Reviewed]

+1 thanx flavio

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996927#comment-12996927 ] 

Hudson commented on ZOOKEEPER-985:
----------------------------------

Integrated in ZooKeeper-trunk #1102 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1102/])
    ZOOKEEPER-985. Test BookieRecoveryTest fails on trunk. (fpj via breed)


> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.3.3, 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996396#comment-12996396 ] 

Flavio Junqueira commented on ZOOKEEPER-985:
--------------------------------------------

The failure is not related to this patch.

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed resolved ZOOKEEPER-985.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.3.3

Committed revision 1072074. (3.3)
Committed revision 1072085. (trunk)


> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.3.3, 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996476#comment-12996476 ] 

Benjamin Reed commented on ZOOKEEPER-985:
-----------------------------------------

looks good flavio. i think the running in Bookie should be volatile.

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-985:
------------------------------------

    Attachment: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt

logs for the tests.

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996500#comment-12996500 ] 

Flavio Junqueira commented on ZOOKEEPER-985:
--------------------------------------------

... and almost forgot: thanks for reviewing it, Ben!

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996368#comment-12996368 ] 

Hadoop QA commented on ZOOKEEPER-985:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12471391/ZOOKEEPER-985.patch
  against trunk revision 1069169.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/138//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/138//console

This message is automatically generated.

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ZOOKEEPER-985) Test BookieRecoveryTest fails on trunk.

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated ZOOKEEPER-985:
---------------------------------------

    Attachment: ZOOKEEPER-985.patch

It applies to both trunk and 3.3.

> Test BookieRecoveryTest fails on trunk.
> ---------------------------------------
>
>                 Key: ZOOKEEPER-985
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-985
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>         Environment: Darwin moststock-lm 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386 (mac).
>            Reporter: Mahadev konar
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.0
>
>         Attachments: TEST-org.apache.bookkeeper.test.BookieRecoveryTest.txt, ZOOKEEPER-985.patch, ZOOKEEPER-985.patch
>
>
> The unit test fails on trunk on my mac. I think this might be the same on other platforms as well. Ill attach the error logs.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira