[GitHub] [incubator-tvm] jroesch commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM

[GitBox <gi...@apache.org>]

jroesch commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM
URL: https://github.com/apache/incubator-tvm/pull/4258#discussion_r342893692
 
 

 ##########
 File path: include/tvm/runtime/vm.h
 ##########
 @@ -286,6 +298,15 @@ struct Instruction {
    */
   static Instruction InvokePacked(Index packed_index, Index arity, Index output_size,
                                   const std::vector<RegName>& args);
+  /*! \brief Construct an invoke external instruction.
+   *  \param packed_index The index of the external function.
+   *  \param ext_arity The arity of the function.
+   *  \param ext_output_size The number of outputs of the external function.
+   *  \param args The argument registers.
+   *  \return The invoke external instruction.
+   */
+  static Instruction InvokeExternal(Index external_index, Index ext_arity, Index ext_output_size,
 
 Review comment:
   Do we actually need a second instruction, shouldn't calling externals be opaque to the VM?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services