You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wangyingdong1 (via GitHub)" <gi...@apache.org> on 2023/07/12 07:11:51 UTC
[GitHub] [nuttx] wangyingdong1 opened a new pull request, #9792: net/udp: Fix the bug of overwriting when the udp recv buffer is full
wangyingdong1 opened a new pull request, #9792:
URL: https://github.com/apache/nuttx/pull/9792
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #9792: net/udp: Fix the bug of overwriting when the udp recv buffer is full
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #9792:
URL: https://github.com/apache/nuttx/pull/9792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #9792: net/udp: Fix the bug of overwriting when the udp recv buffer is full
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #9792:
URL: https://github.com/apache/nuttx/pull/9792#discussion_r1261147196
##########
net/udp/udp_callback.c:
##########
@@ -228,10 +228,6 @@ net_dataevent(FAR struct net_driver_s *dev, FAR struct udp_conn_s *conn,
*/
ninfo("Dropped %d bytes\n", dev->d_len);
-
-#ifdef CONFIG_NET_STATISTICS
- g_netstats.udp.drop++;
-#endif
Review Comment:
Why net statistics for UDP packet drop is not increased in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9792: net/udp: Fix the bug of overwriting when the udp recv buffer is full
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9792:
URL: https://github.com/apache/nuttx/pull/9792#issuecomment-1632490495
Please include the Summary and the commit message explaining the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org