[GitHub] [spark] rshkv commented on a change in pull request #29977: [SPARK-33088][CORE] Enhance ExecutorPlugin API to include callbacks on task start and end events

[GitBox <gi...@apache.org>]

rshkv commented on a change in pull request #29977:
URL: https://github.com/apache/spark/pull/29977#discussion_r501837781



##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -332,7 +332,8 @@ private[spark] class Executor(
 
   class TaskRunner(
       execBackend: ExecutorBackend,
-      private val taskDescription: TaskDescription)
+      private val taskDescription: TaskDescription,
+      private val plugins: Option[PluginContainer])

Review comment:
       Maybe we can make the `plugins` parameter optional or default to some `EmptyPluginContainer`?:
   ```suggestion
         private val plugins: Option[PluginContainer] = None)
   ```

##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -332,7 +332,8 @@ private[spark] class Executor(
 
   class TaskRunner(
       execBackend: ExecutorBackend,
-      private val taskDescription: TaskDescription)
+      private val taskDescription: TaskDescription,
+      private val plugins: Option[PluginContainer])

Review comment:
       Same for `Task#run`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org