You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/24 10:04:09 UTC

[GitHub] [rocketmq] ShadowySpirits opened a new issue, #5589: [OPTIMIZATION] Record subscriptions from request

ShadowySpirits opened a new issue, #5589:
URL: https://github.com/apache/rocketmq/issues/5589

   Recently, RocketMQ introduced some lite consumption modes such as simple consumer and pop. They reduce the complexity for users to use, but bring new problems: brokers can not get consumer subscriptions from the heartbeat. Moreover, consumers via proxy won't send heartbeat to the broker. 
   
   So we need a compensation mechanism to record subscriptions from requests so that existing functionality like lag calculating is not affected. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] francisoliverlee commented on issue #5589: [OPTIMIZATION] Record subscriptions from request

Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on issue #5589:
URL: https://github.com/apache/rocketmq/issues/5589#issuecomment-1328205913

   > 
   据我所知， 5.0.0 目前客户端访问收发消息的路径包含, 可以统计下你目前发现了哪些有问题，是可以PR修复的。
   1. pull consumer -> broker
   2. push consumer -> broker
   3. pop push consumer -> broker
   4. lite pull consumer -> broker
   5. grpc client (比如java) -> proxy -> broker
   
   
   在5.0.0release中，我检查了proxy pop消息时， 订阅关系会查询不到，消费消息异常。 其他的你可以详细确认下
   客户端pop消息报错：
   ![image](https://user-images.githubusercontent.com/5908412/204128247-3fc586b2-147a-4ff3-a8c9-3a592d2f96fc.png)
   
   broker检测订阅关系不存在：
   ![image](https://user-images.githubusercontent.com/5908412/204128033-787b29e0-58c5-4f6c-81ef-bd3d5b0119fc.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ShadowySpirits commented on issue #5589: [OPTIMIZATION] Record subscriptions from request

Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on issue #5589:
URL: https://github.com/apache/rocketmq/issues/5589#issuecomment-1330146522

   > > 
   > 
   > 据我所知， 5.0.0 目前客户端访问收发消息的路径包含, 可以统计下你目前发现了哪些有问题，是可以PR修复的。
   > 
   > 1. pull consumer -> broker
   > 2. push consumer -> broker
   > 3. pop push consumer -> broker
   > 4. lite pull consumer -> broker
   > 5. grpc client (比如java) -> proxy -> broker
   > 
   > 在5.0.0release中，我检查了proxy pop消息时， 消费者组在提前创建好和broker自动创建的时候都可以。 在findSubscriptionGroupConfig() 是可以找到或者在这里被自动创建
   > 
   > ![image](https://user-images.githubusercontent.com/5908412/204128033-787b29e0-58c5-4f6c-81ef-bd3d5b0119fc.png)
   
   这个 PR 要解决的问题是“订阅关系（Subscription）”，`findSubscriptionGroupConfig`是查找“订阅组（Group）”，这是两个不同的概念


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhimins closed issue #5589: [OPTIMIZATION] Record subscriptions from request

Posted by GitBox <gi...@apache.org>.
lizhimins closed issue #5589: [OPTIMIZATION] Record subscriptions from request
URL: https://github.com/apache/rocketmq/issues/5589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ShadowySpirits commented on issue #5589: [OPTIMIZATION] Record subscriptions from request

Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on issue #5589:
URL: https://github.com/apache/rocketmq/issues/5589#issuecomment-1328193604

   > 你好， 5.0.0使用pop消费有两种方式
   > 
   > 1. pop push consumer --> broker
   > 2. proxy --> broker
   > 
   > 可以举例说明下哪种情况订阅关系没有被记录嘛？
   
   所有没有心跳或者心跳没有包含订阅关系 broker 的情况下 broker 不会感知订阅关系，例如：
   1. 客户端通过 proxy 消费：心跳没有发往 broker
   2. pull 消费者：心跳没有包含订阅关系


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] francisoliverlee commented on issue #5589: [OPTIMIZATION] Record subscriptions from request

Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on issue #5589:
URL: https://github.com/apache/rocketmq/issues/5589#issuecomment-1328191628

   你好， 5.0.0使用pop消费有两种方式
   1. pop push consumer --> broker
   2. proxy --> broker
   
   可以举例说明下哪种情况订阅关系没有被记录嘛？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org