Re: [PR] GH-44810 [C++][Parquet] Added `arrow::Result` version of `parquet::arrow::FileReader::Make()` [arrow]

["malinjawi (via GitHub)" <gi...@apache.org>]

malinjawi commented on code in PR #44819:
URL: https://github.com/apache/arrow/pull/44819#discussion_r1866106722


##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1315,15 +1315,15 @@ Status FileReader::GetRecordBatchReader(const std::vector<int>& row_group_indice
   return Status::OK();
 }
 
-Status FileReader::Make(::arrow::MemoryPool* pool,
+Result<std::unique_ptr<FileReader>> Make(::arrow::MemoryPool* pool,
                         std::unique_ptr<ParquetFileReader> reader,
                         const ArrowReaderProperties& properties,
                         std::unique_ptr<FileReader>* out) {

Review Comment:
   Hey @raulcd updated this but I think i got something wrong on how to use the `std::unique_ptr<FileReader>* out` internally in the function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org