You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/15 08:26:48 UTC
[GitHub] [apisix-dashboard] starsz opened a new pull request #1054: fix: ssl config support set labels
starsz opened a new pull request #1054:
URL: https://github.com/apache/apisix-dashboard/pull/1054
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
fix #1050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1054: fix: ssl config support set labels
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1054:
URL: https://github.com/apache/apisix-dashboard/pull/1054#issuecomment-760612299
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=h1) Report
> Merging [#1054](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=desc) (5fc45b7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 44.19% 44.23% +0.03%
==========================================
Files 31 31
Lines 1948 1951 +3
==========================================
+ Hits 861 863 +2
- Misses 975 976 +1
Partials 112 112
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1054/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.76% <100.00%> (+1.16%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1054/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.88% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=footer). Last update [754f559...5fc45b7](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1054: fix: ssl config support set labels
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1054:
URL: https://github.com/apache/apisix-dashboard/pull/1054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1054: fix: ssl config support set labels
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1054:
URL: https://github.com/apache/apisix-dashboard/pull/1054#issuecomment-760612299
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=h1) Report
> Merging [#1054](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=desc) (3afe37a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5f2232603588a47f902a90d974692a7c6bea535f?el=desc) (5f22326) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 42.44% 42.53% +0.08%
==========================================
Files 31 31
Lines 1932 1935 +3
==========================================
+ Hits 820 823 +3
Misses 1001 1001
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1054/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.38% <100.00%> (+1.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=footer). Last update [5f22326...3afe37a](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org