[GitHub] [superset] geido commented on a change in pull request #18558: chore: Rename and reposition native filter modal fields

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #18558:
URL: https://github.com/apache/superset/pull/18558#discussion_r800926560



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
##########
@@ -104,7 +90,12 @@ const FilterTitlePane: React.FC<Props> = ({
   );
   return (
     <TabsContainer>
-      <StyledHeader>Filters</StyledHeader>
+      <Dropdown overlay={menu} arrow placement="topLeft" trigger={['hover']}>
+        <StyledAddBox>
+          <div data-test="new-dropdown-icon" className="fa fa-plus" />{' '}
+          <span>{t('Add Filters and Dividers')}</span>

Review comment:
       Super nit. It looks like we are using camel case for headers but I don't think we are for the buttons. Should this be `Add filters and dividers` instead?
   
   ```suggestion
             <span>{t('Add filters and dividers')}</span>
   ```
   
   P.S. If you accept this change Cypress will need to be updated as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org