[GitHub] [lucene] dweiss commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r836748820



##########
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##########
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
     assertEquals((Integer) 2, pq.top());
   }
 
+  public void testAddAllToEmptyQueue() {
+    int size = 10;
+    List<Integer> list = new ArrayList<>();
+    for (int i = 0; i < size; i++) {
+      list.add(random().nextInt());
+    }
+    IntegerQueue pq = new IntegerQueue(size);
+    pq.addAll(list);
+    pq.checkValidity();
+  }
+
+  public void testAddAllToPartiallyFilledQueue() {
+    IntegerQueue pq = new IntegerQueue(20);
+    List<Integer> list = new ArrayList<>();
+    for (int i = 0; i < 10; i++) {
+      list.add(random().nextInt());
+      pq.add(random().nextInt());
+    }
+    pq.addAll(list);
+    pq.checkValidity();

Review comment:
       Wouldn't it be good to cross-check against some other implementation of a PQ (or even a set) and make sure the elements held in both are the same? I'd also pull out random() outside any loop - this call is costly (the returned Random is cheap).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org