[jira] [Commented] (CLOUDSTACK-1168) Create firewall rule broken

["Marcus Sorensen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571964#comment-13571964 ] 

Marcus Sorensen commented on CLOUDSTACK-1168:
---------------------------------------------

Assigning to Jayapal, since a git blame shows that createIngressFirewallRule was edited by him on 1-31-2013
                
> Create firewall rule broken
> ---------------------------
>
>                 Key: CLOUDSTACK-1168
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1168
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Network Controller
>    Affects Versions: 4.1.0
>         Environment: devcloud
>            Reporter: Marcus Sorensen
>            Assignee: Jayapal Reddy
>
> Following code, get null pointer in server/src/com/cloud/network/firewall/FirewallManagerImpl.java at 484 due to object 'trafficType'.
> Follow this up to createFirewallRule, then to createIngressFirewallRule, where we see rule.getTrafficType() then to file CreateFirewallRuleCmd.java:
>     public TrafficType getTrafficType() {
>         return null;
>     }
> I think we should modify createIngressFirewallRule and createEgressFirewallRule to pass FirewallRule.TrafficType.Ingress and FirewallRule.TrafficType.Egress, but does anyone who is responsible for this code want to take a look? Maybe we need to look at other places that might be affected?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira