You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/05/02 03:43:55 UTC

[jira] Created: (GERONIMO-5281) MergeHelper should not load all classes in bundle

MergeHelper should not load all classes in bundle
-------------------------------------------------

                 Key: GERONIMO-5281
                 URL: https://issues.apache.org/jira/browse/GERONIMO-5281
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: web
    Affects Versions: 3.0
            Reporter: David Jencks
            Assignee: Ivan
             Fix For: 3.0


MergeHelper line 318 appears to be loading all classes in the bundle.  It's entirely possible that someone will be deploying a war where some of the classes can't be loaded due to something like missing optional dependencies.  Also loading classes can run their initializers with unexpected consequences.

Instead, we should see if there is some way to use asm to scan for classes that subclass the handled classes (line 338)

I'm running into this problem trying to build trunk, uddi-jetty.  Most likely the error I'm seeing is something that needs to be fixed for juddi to work, but I think trying to load all the classes is a mistake.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5281) MergeHelper should not load all classes in bundle

Posted by "Ivan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863080#action_12863080 ] 

Ivan commented on GERONIMO-5281:
--------------------------------

Yes, actually I have already added a TODO tag line 294 while I commit the codes, will do it on the next step.

> MergeHelper should not load all classes in bundle
> -------------------------------------------------
>
>                 Key: GERONIMO-5281
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5281
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: web
>    Affects Versions: 3.0
>            Reporter: David Jencks
>            Assignee: Ivan
>             Fix For: 3.0
>
>
> MergeHelper line 318 appears to be loading all classes in the bundle.  It's entirely possible that someone will be deploying a war where some of the classes can't be loaded due to something like missing optional dependencies.  Also loading classes can run their initializers with unexpected consequences.
> Instead, we should see if there is some way to use asm to scan for classes that subclass the handled classes (line 338)
> I'm running into this problem trying to build trunk, uddi-jetty.  Most likely the error I'm seeing is something that needs to be fixed for juddi to work, but I think trying to load all the classes is a mistake.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-5281) MergeHelper should not load all classes in bundle

Posted by "Ivan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan resolved GERONIMO-5281.
----------------------------

    Resolution: Fixed

This should be fixed, a new ASM ClassFinder is added in xbean-finder.

> MergeHelper should not load all classes in bundle
> -------------------------------------------------
>
>                 Key: GERONIMO-5281
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5281
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: web
>    Affects Versions: 3.0
>            Reporter: David Jencks
>            Assignee: Ivan
>             Fix For: 3.0
>
>
> MergeHelper line 318 appears to be loading all classes in the bundle.  It's entirely possible that someone will be deploying a war where some of the classes can't be loaded due to something like missing optional dependencies.  Also loading classes can run their initializers with unexpected consequences.
> Instead, we should see if there is some way to use asm to scan for classes that subclass the handled classes (line 338)
> I'm running into this problem trying to build trunk, uddi-jetty.  Most likely the error I'm seeing is something that needs to be fixed for juddi to work, but I think trying to load all the classes is a mistake.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5281) MergeHelper should not load all classes in bundle

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick McGuire updated GERONIMO-5281:
-----------------------------------

    Fix Version/s: 3.0-M1
                       (was: 3.0)

> MergeHelper should not load all classes in bundle
> -------------------------------------------------
>
>                 Key: GERONIMO-5281
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5281
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: web
>    Affects Versions: 3.0
>            Reporter: David Jencks
>            Assignee: Ivan
>             Fix For: 3.0-M1
>
>
> MergeHelper line 318 appears to be loading all classes in the bundle.  It's entirely possible that someone will be deploying a war where some of the classes can't be loaded due to something like missing optional dependencies.  Also loading classes can run their initializers with unexpected consequences.
> Instead, we should see if there is some way to use asm to scan for classes that subclass the handled classes (line 338)
> I'm running into this problem trying to build trunk, uddi-jetty.  Most likely the error I'm seeing is something that needs to be fixed for juddi to work, but I think trying to load all the classes is a mistake.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.