[GitHub] [flink] Myasuka commented on a diff in pull request #21485: [FLINK-29997] Link to the taskmanager page in the expired sub-task of…

[GitBox <gi...@apache.org>]

Myasuka commented on code in PR #21485:
URL: https://github.com/apache/flink/pull/21485#discussion_r1046670197


##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html:
##########
@@ -181,7 +186,19 @@
           <td>{{ subTask['unaligned_checkpoint'] }}</td>
         </ng-container>
         <ng-container *ngIf="subTask['status'] === 'pending_or_failed'">
-          <td colspan="8">n/a</td>
+          <td colspan="10">n/a</td>
+          <td>
+            <a
+              *ngIf="mapOfSubtask.get(subTask['index'])"
+              [routerLink]="[
+                '/task-manager',
+                mapOfSubtask.get(subTask['index'])['taskmanager-id'],
+                'logs'

Review Comment:
   I noticed the link has changed to `logs`, would you please share the new picture with this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org