You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/06/05 16:21:22 UTC
[whimsy] branch master updated (8626686 -> 759fcfe)
This is an automated email from the ASF dual-hosted git repository.
sebb pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git.
from 8626686 Add password-from-stdin checking
new fa34e86 Seems OK
new 759fcfe Make it local to this class
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
lib/whimsy/asf/svn.rb | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[whimsy] 02/02: Make it local to this class
Posted by se...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
commit 759fcfee1c2690b3c554e6cc28e3b791a34be5f4
Author: Sebb <se...@apache.org>
AuthorDate: Fri Jun 5 17:21:11 2020 +0100
Make it local to this class
---
lib/whimsy/asf/svn.rb | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index 459be5a..d88d36e 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -24,7 +24,7 @@ module ASF
untaint
@@repository_mtime = nil
@@repository_entries = nil
- @@svnHasPasswordFromStdin = nil
+ @svnHasPasswordFromStdin = nil
# a hash of local working copies of Subversion repositories. Keys are
# subversion paths; values are file paths.
@@ -712,14 +712,14 @@ module ASF
# Does this host's installation of SVN support --password-from-stdin?
def self.passwordStdinOK?()
- return @@svnHasPasswordFromStdin if @@svnHasPasswordFromStdin
+ return @svnHasPasswordFromStdin if @svnHasPasswordFromStdin
out,err = self.svn('help','cat', {args: '-v'})
if out
- @@svnHasPasswordFromStdin = out.include? '--password-from-stdin'
+ @svnHasPasswordFromStdin = out.include? '--password-from-stdin'
else
- @@svnHasPasswordFromStdin = false
+ @svnHasPasswordFromStdin = false
end
- @@svnHasPasswordFromStdin
+ @svnHasPasswordFromStdin
end
private
[whimsy] 01/02: Seems OK
Posted by se...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
commit fa34e86d9b92e2dbcf085f1fd7ddfdd56ebeaee6
Author: Sebb <se...@apache.org>
AuthorDate: Fri Jun 5 17:17:40 2020 +0100
Seems OK
---
lib/whimsy/asf/svn.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index bf3c215..459be5a 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -310,7 +310,7 @@ module ASF
# password was supplied, add credentials
if password
cmd += ['--username', user, '--no-auth-cache']
- if ASF::Config[:password_from_stdin] # TODO: better way to check this?
+ if self.passwordStdinOK?()
open_opts[:stdin_data] = password
cmd << '--password-from-stdin'
else