You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Jessica Abraham <ja...@mitre.org> on 2012/01/17 23:38:16 UTC
Review Request: Rave-360 New Account Page needs to be updated to let user
enter more information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3515/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Rave 360
Also updated the user details page to display the new information added for an account
Diffs
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1232614
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1232614
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1232614
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/userdetail.jsp 1232614
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1232614
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_forms.js 1232614
Diff: https://reviews.apache.org/r/3515/diff
Testing
-------
Thanks,
Jessica
Re: Review Request: Rave-360 New Account Page needs to be updated to let
user enter more information
Posted by Jessica Abraham <ja...@mitre.org>.
> On 2012-01-19 16:15:23, Marlon Pierce wrote:
> >
Hi Marlon,
Looks like Rave 421, is the exact same task as Rave 360...and it seems like you approved that one. Just go with that one and ignore mine. Thanks!
Jessica
- Jessica
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3515/#review4474
-----------------------------------------------------------
On 2012-01-17 22:38:16, Jessica Abraham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3515/
> -----------------------------------------------------------
>
> (Updated 2012-01-17 22:38:16)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> Rave 360
>
> Also updated the user details page to display the new information added for an account
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/userdetail.jsp 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_forms.js 1232614
>
> Diff: https://reviews.apache.org/r/3515/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jessica
>
>
Re: Review Request: Rave-360 New Account Page needs to be updated to let
user enter more information
Posted by Marlon Pierce <mp...@cs.indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3515/#review4474
-----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties
<https://reviews.apache.org/r/3515/#comment10038>
For some reason, my Unix patch didn't like these.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties
<https://reviews.apache.org/r/3515/#comment10037>
These need to be translated.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql
<https://reviews.apache.org/r/3515/#comment10039>
The license header MUST be retained.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp
<https://reviews.apache.org/r/3515/#comment10043>
I think you are missing some corresponding getter/setter methods in NewUser.java
- Marlon
On 2012-01-17 22:38:16, Jessica Abraham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3515/
> -----------------------------------------------------------
>
> (Updated 2012-01-17 22:38:16)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> Rave 360
>
> Also updated the user details page to display the new information added for an account
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/userdetail.jsp 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1232614
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_forms.js 1232614
>
> Diff: https://reviews.apache.org/r/3515/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jessica
>
>