[jira] [Commented] (GIRAPH-962) TextAggregatorWriter with frequency AT_THE_END writes in every superstep

["Martin Junghanns (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191609#comment-14191609 ] 

Martin Junghanns commented on GIRAPH-962:
-----------------------------------------

Forgot to mention: {{mvn clean verify}} finished with Build Success

> TextAggregatorWriter with frequency AT_THE_END writes in every superstep
> ------------------------------------------------------------------------
>
>                 Key: GIRAPH-962
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-962
>             Project: Giraph
>          Issue Type: Bug
>          Components: bsp
>    Affects Versions: 1.1.0
>            Reporter: Martin Junghanns
>            Priority: Minor
>              Labels: aggregator, bsp
>             Fix For: 1.1.0
>
>         Attachments: GIRAPH-962.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> TextAggregatorWriter is used to write the content of all aggregators in a superstep to a text file. It offers three predefined frequencies:
> {{NEVER (0)}}
> {{ALWAYS (1) // in each superstep}}
> {{AT_THE_END (-1) // only in the last superstep}}
> The aggregators are written in a superstep if the following condition evaluates to true:
> {{(frequeny == AT_THE_END && superstep == LAST_SUPERSTEP) || (frequency != NEVER && superstep % frequency == 0)}}
> The problem is, that {{LAST_SUPERSTEP}} is represented by {{-1}} and {{x % -1 = 0}} for all {{x}}. This leads to the case, that if {{frequency = AT_THE_END}}, the content is written in every superstep.
> On way to solve this is to extend the second part of the OR-clause to {{(frequency != NEVER && frequency != AT_THE_END && superstep % frequency == 0)}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)