You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/14 20:29:26 UTC
[GitHub] [incubator-druid] clintropolis commented on a change in pull
request #7267: Logic adjustments to SeekableStreamIndexTaskRunner.
clintropolis commented on a change in pull request #7267: Logic adjustments to SeekableStreamIndexTaskRunner.
URL: https://github.com/apache/incubator-druid/pull/7267#discussion_r265747949
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -498,34 +515,17 @@ public void run()
SequenceMetadata sequenceToCheckpoint = null;
for (OrderedPartitionableRecord<PartitionIdType, SequenceOffsetType> record : records) {
-
-
- // for Kafka, the end offsets are exclusive, so skip it
- if (isEndSequenceOffsetsExclusive() &&
- createSequenceNumber(record.getSequenceNumber()).compareTo(
- createSequenceNumber(endOffsets.get(record.getPartitionId()))) >= 0) {
- continue;
- }
-
- // for the first message we receive, check that we were given a message with a sequenceNumber that matches
- // our expected starting sequenceNumber
- if (!verifyInitialRecordAndSkipExclusivePartition(record)) {
- continue;
- }
+ final boolean shouldProcess = verifyRecordInRange(record.getPartitionId(), record.getSequenceNumber());
log.trace(
- "Got stream[%s] partition[%s] sequence[%s].",
+ "Got topic[%s] partition[%s] offset[%s], shouldProcess[%s].",
Review comment:
I personally prefer `offset` over `sequence` because the former is more obviously a position to me, but am indifferent about whether `stream` or `topic`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org