You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by "Beckerle, Mike" <mb...@owlcyberdefense.com> on 2020/09/28 15:15:30 UTC
Turn back on emails from coverage.io
I'd like to turn back on emails coming from the automated coverage analysis.
Since I had no idea this was even still running automatically, I think more noise from this it is not a distraction. At least that tells us if the automated checking still works, and a quick check of the email rules out major regression on these metrics.
I also think we should put links to these on the release notes pages. Each release copies these pages from a prior and adapts those pages for the release. Having a section that links to the reports for the specific release would be useful and serves as the reminder to study them a bit per release.
E.g, for 2.7.0 this pages is the specific coverage report for that release.
https://codecov.io/gh/apache/incubator-daffodil/commit/0ddaea2c29bbed35e2a4e62233545bb9357db68d/graphs/sunburst
However, I looked at the sonarcube page, but I couldn't figure out how to get the sonarcube output page for a specific commit.
[cid:824b15bf-bfee-4b3d-b3c1-dab944bc2fce] Mike Beckerle | Principal Engineer
[OWL Cyber Defense]
P +1-781-330-0412
W owlcyberdefense.com<http://www.owlcyberdefense.com>
Re: Turn back on emails from coverage.io
Posted by Steve Lawrence <sl...@apache.org>.
Yeah, codecov doesn't have the greatest UI. I suggest we just turn on
the PR comments and see how it goes. If we find it spammy or not
helpful, we can see if we can configure it to make it more useful, or
just disable it again and better document it so that it's more visible.
On 9/29/20 2:57 PM, Interrante, John A (GE Research, US) wrote:
> Nice, clicking the badge on the main GitHub page takes me to the codecov report. Not so nice, the codecov UI doesn't give me something I can act on easily since I'm not familiar with codecov reports and they're not very intuitive.
>
> This leads me to reserve judgment how useful a codecov email might be until I see an actual email. The email would have to be very intuitive and easy to understand. I did see how https://docs.codecov.io/docs/pull-request-comments allows codecov to add comments to PRs and that screenshot does look fairly clear and actionable with checkmarks and red crosses.
>
> John
>
> -----Original Message-----
> From: Steve Lawrence <sl...@apache.org>
> Sent: Tuesday, September 29, 2020 8:44 AM
> To: dev@daffodil.apache.org
> Subject: EXT: Re: Turn back on emails from coverage.io
>
> All seem like reasonable suggestions to me. Currently the only place the coverage is really visible is the badge we have on the main github page
>
> https://github.com/apache/incubator-daffodil
>
> I think all we need to do is delete/modify this config:
>
> https://github.com/apache/incubator-daffodil/blob/master/.codecov.yml
>
> And it looks like codecov has a bunch of configuration options for how it should add comments to PRs. Whoeer make this change should probably look through this and see if anything is worth changing in the default
> config:
>
> https://docs.codecov.io/docs/pull-request-comments
>
>
>
>
> On 9/28/20 11:15 AM, Beckerle, Mike wrote:
>> I'd like to turn back on emails coming from the automated coverage analysis.
>>
>> Since I had no idea this was even still running automatically, I think
>> more noise from this it is not a distraction. At least that tells us
>> if the automated checking still works, and a quick check of the email
>> rules out major regression on these metrics.
>>
>> I also think we should put links to these on the release notes pages.
>> Each release copies these pages from a prior and adapts those pages for the release.
>> Having a section that links to the reports for the specific release
>> would be useful and serves as the reminder to study them a bit per release.
>>
>> E.g, for 2.7.0 this pages is the specific coverage report for that release.
>>
>> https://codecov.io/gh/apache/incubator-daffodil/commit/0ddaea2c29bbed3
>> 5e2a4e62233545bb9357db68d/graphs/sunburst
>>
>> However, I looked at the sonarcube page, but I couldn't figure out how
>> to get the sonarcube output page for a specific commit.
>>
>>
>>
>> Mike Beckerle | Principal Engineer
>>
>> OWL Cyber Defense
>>
>> P +1-781-330-0412
>> W owlcyberdefense.com <http://www.owlcyberdefense.com>
>>
>
Turn back on emails from coverage.io
Posted by "Interrante, John A (GE Research, US)" <in...@research.ge.com>.
Nice, clicking the badge on the main GitHub page takes me to the codecov report. Not so nice, the codecov UI doesn't give me something I can act on easily since I'm not familiar with codecov reports and they're not very intuitive.
This leads me to reserve judgment how useful a codecov email might be until I see an actual email. The email would have to be very intuitive and easy to understand. I did see how https://docs.codecov.io/docs/pull-request-comments allows codecov to add comments to PRs and that screenshot does look fairly clear and actionable with checkmarks and red crosses.
John
-----Original Message-----
From: Steve Lawrence <sl...@apache.org>
Sent: Tuesday, September 29, 2020 8:44 AM
To: dev@daffodil.apache.org
Subject: EXT: Re: Turn back on emails from coverage.io
All seem like reasonable suggestions to me. Currently the only place the coverage is really visible is the badge we have on the main github page
https://github.com/apache/incubator-daffodil
I think all we need to do is delete/modify this config:
https://github.com/apache/incubator-daffodil/blob/master/.codecov.yml
And it looks like codecov has a bunch of configuration options for how it should add comments to PRs. Whoeer make this change should probably look through this and see if anything is worth changing in the default
config:
https://docs.codecov.io/docs/pull-request-comments
On 9/28/20 11:15 AM, Beckerle, Mike wrote:
> I'd like to turn back on emails coming from the automated coverage analysis.
>
> Since I had no idea this was even still running automatically, I think
> more noise from this it is not a distraction. At least that tells us
> if the automated checking still works, and a quick check of the email
> rules out major regression on these metrics.
>
> I also think we should put links to these on the release notes pages.
> Each release copies these pages from a prior and adapts those pages for the release.
> Having a section that links to the reports for the specific release
> would be useful and serves as the reminder to study them a bit per release.
>
> E.g, for 2.7.0 this pages is the specific coverage report for that release.
>
> https://codecov.io/gh/apache/incubator-daffodil/commit/0ddaea2c29bbed3
> 5e2a4e62233545bb9357db68d/graphs/sunburst
>
> However, I looked at the sonarcube page, but I couldn't figure out how
> to get the sonarcube output page for a specific commit.
>
>
>
> Mike Beckerle | Principal Engineer
>
> OWL Cyber Defense
>
> P +1-781-330-0412
> W owlcyberdefense.com <http://www.owlcyberdefense.com>
>
Re: Turn back on emails from coverage.io
Posted by Steve Lawrence <sl...@apache.org>.
All seem like reasonable suggestions to me. Currently the only place the
coverage is really visible is the badge we have on the main github page
https://github.com/apache/incubator-daffodil
I think all we need to do is delete/modify this config:
https://github.com/apache/incubator-daffodil/blob/master/.codecov.yml
And it looks like codecov has a bunch of configuration options for how
it should add comments to PRs. Whoeer make this change should probably
look through this and see if anything is worth changing in the default
config:
https://docs.codecov.io/docs/pull-request-comments
On 9/28/20 11:15 AM, Beckerle, Mike wrote:
> I'd like to turn back on emails coming from the automated coverage analysis.
>
> Since I had no idea this was even still running automatically, I think more
> noise from this it is not a distraction. At least that tells us if the automated
> checking still works, and a quick check of the email rules out major regression
> on these metrics.
>
> I also think we should put links to these on the release notes pages. Each
> release copies these pages from a prior and adapts those pages for the release.
> Having a section that links to the reports for the specific release would be
> useful and serves as the reminder to study them a bit per release.
>
> E.g, for 2.7.0 this pages is the specific coverage report for that release.
>
> https://codecov.io/gh/apache/incubator-daffodil/commit/0ddaea2c29bbed35e2a4e62233545bb9357db68d/graphs/sunburst
>
> However, I looked at the sonarcube page, but I couldn't figure out how to get
> the sonarcube output page for a specific commit.
>
>
>
> Mike Beckerle | Principal Engineer
>
> OWL Cyber Defense
>
> P +1-781-330-0412
> W owlcyberdefense.com <http://www.owlcyberdefense.com>
>